docs: HACKING.md: add custom payload build section #425

runcom · 2019-02-13T21:10:28Z

Please go over it by testing the flow as well to make sure it's correct (I just did and it works for me (tm)).
Please also correct any of my mistakes in english lol

Signed-off-by: Antonio Murdaca [email protected]

cgwalters

Looks great to me! Looking forward to trying this out.

docs/HACKING.md

cgwalters · 2019-02-13T21:12:44Z

docs/HACKING.md

There's also make image-controller make image-daemon etc.

omg, how have I missed those 😥

kikisdeliveryservice

Some minor comments. This is great!

kikisdeliveryservice · 2019-02-13T21:16:22Z

docs/HACKING.md

"tesing" -> "testing"

kikisdeliveryservice · 2019-02-13T21:16:53Z

docs/HACKING.md

i think delete "for any of the component"

kikisdeliveryservice · 2019-02-13T21:17:55Z

docs/HACKING.md

"that would" -> "that"

kikisdeliveryservice · 2019-02-13T21:20:12Z

docs/HACKING.md

"into" -> "in"

kikisdeliveryservice · 2019-02-13T21:20:43Z

docs/HACKING.md

"any of the" -> "any"

kikisdeliveryservice · 2019-02-13T21:25:36Z

Generally, I'm wondering at what point we start breaking some of these sections out into their own pages and just link to them in HACKING.MD bc it's getting long.

runcom · 2019-02-13T21:34:33Z

Generally, I'm wondering at what point we start breaking some of these sections out into their own pages and just link to them in HACKING.MD bc it's getting long.

I can do that as part of this PR if you want to, any idea on how to break it down to different pages?

kikisdeliveryservice · 2019-02-13T22:13:33Z

@runcom I'm ok with not doing it here. I think once this is in, we can take stock of what we have and decide how we'd like to organize it going forward. 😄

runcom · 2019-02-13T22:47:22Z

docs/HACKING.md

there's a known limitation now in code for this though #421, which can be worked around with #421 (basically all operands have to be at the very same version or the installation just fails).
That can be worked around by bundling all the components though (see #421 (comment))

Probably worth just mentioning this limitation and link to the issue directly in the docs.

runcom · 2019-02-13T22:47:45Z

/hold

Holding due to https://github.com/openshift/machine-config-operator/pull/425/files#r256622962 but please keep testing this 🎉

jlebon

Some minor tweaks, otherwise LGTM!

jlebon · 2019-02-14T14:53:58Z

docs/HACKING.md

Hmm, seems like this sentence should be before the previous one?

jlebon · 2019-02-14T15:22:42Z

docs/HACKING.md

jlebon · 2019-02-14T15:27:28Z

docs/HACKING.md

runcom · 2019-02-14T17:39:10Z

/hold cancel

because I've addressed #425 (comment)

kikisdeliveryservice · 2019-02-14T20:24:54Z

I'm a little confused here what am I supposed to do for this particular part
--to-image quay.io/user/origin-release:v4.0 \

I get building the mco components and adding but am I supposed to somehow build origin-release:v4.0??

runcom · 2019-02-14T20:33:16Z

I get building the mco components and adding but am I supposed to somehow build origin-release:v4.0??

that image is the output of oc adm release new itself, it gets produced as part of that command and gets automagically pushed as well so you can use it with the installer

cgwalters · 2019-02-14T20:39:46Z

/lgtm

Signed-off-by: Antonio Murdaca <[email protected]>

runcom · 2019-02-14T20:51:08Z

repushed cause I've missed some backslashes (thanks @kikisdeliveryservice )

kikisdeliveryservice · 2019-02-14T20:51:27Z

/lgtm

openshift-ci-robot · 2019-02-14T20:51:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters,kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rphillips · 2019-02-14T20:56:12Z

Thanks for writing this up. Looks awesome!

openshift-ci-robot requested review from jlebon and wking February 13, 2019 21:10

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2019

runcom force-pushed the docs-custom-release-payload branch from 5e1dfa7 to 35f01bb Compare February 13, 2019 21:11

cgwalters reviewed Feb 13, 2019

View reviewed changes

runcom force-pushed the docs-custom-release-payload branch 3 times, most recently from a39246e to ad7cd76 Compare February 13, 2019 21:21

kikisdeliveryservice reviewed Feb 13, 2019

View reviewed changes

runcom commented Feb 13, 2019

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2019

jlebon mentioned this pull request Feb 14, 2019

server: Implement "early pivot" before the MCD comes up #426

Merged

jlebon reviewed Feb 14, 2019

View reviewed changes

runcom force-pushed the docs-custom-release-payload branch from ad7cd76 to 5cc653c Compare February 14, 2019 17:38

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2019

openshift-ci-robot assigned cgwalters Feb 14, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019

docs: HACKING.md: add custom payload build section

655ec6e

Signed-off-by: Antonio Murdaca <[email protected]>

runcom force-pushed the docs-custom-release-payload branch from 5cc653c to 655ec6e Compare February 14, 2019 20:50

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019

openshift-ci-robot assigned kikisdeliveryservice Feb 14, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019

openshift-merge-robot merged commit e4d3b48 into openshift:master Feb 14, 2019

runcom deleted the docs-custom-release-payload branch February 14, 2019 21:18

docs: HACKING.md: add custom payload build section #425

docs: HACKING.md: add custom payload build section #425

Uh oh!

Conversation

runcom commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgwalters left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kikisdeliveryservice commented Feb 13, 2019

Uh oh!

runcom commented Feb 13, 2019

Uh oh!

kikisdeliveryservice commented Feb 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

runcom commented Feb 13, 2019

Uh oh!

jlebon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

runcom commented Feb 14, 2019

Uh oh!

kikisdeliveryservice commented Feb 14, 2019

Uh oh!

runcom commented Feb 14, 2019

Uh oh!

cgwalters commented Feb 14, 2019

Uh oh!

runcom commented Feb 14, 2019

Uh oh!

kikisdeliveryservice commented Feb 14, 2019

Uh oh!

openshift-ci-robot commented Feb 14, 2019

Uh oh!

rphillips commented Feb 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

runcom commented Feb 13, 2019 •

edited

Loading