-
Notifications
You must be signed in to change notification settings - Fork 462
append kube-ca to root-ca for mco config #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abhinavdahiya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make sure that the operator/bootstrap.go does the same thing
|
@abhinavdahiya thanks, updated. |
|
Got |
To debug that you usually want to look at the MCO logs from the pods. In this case looking at the MCC: Looks like this hit #338 |
|
/retest |
|
needs a rebase |
|
/retest |
Yes, that's what you need to do for now. Squash that into the previous commit, then land this - then you can update the installer to pass it as an argument, and then finally remove the default here. We've done this multiple times now for MCO/installer interlocking issues. |
|
@cgwalters I've squashed the commits, and testing looks good. PTAL. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Wire in the --kube-ca option after openshift/machine-config-operator#420.
For openshift/installer#1179 it's necessary to include the now self-signed kube-ca in the /etc/kubernetes/ca.crt file for kubelets, since the PR makes root-ca no longer a valid trust anchor for the API server certs. I think this is the correct spot to modify to change /etc/kubernetes/ca.crt, and I'm opting to append it rather than replace the root CA for now to make sure nothing else breaks. (There might be a different configmap that it would be better to grab kube-ca from.)
/cc @abhinavdahiya @deads2k @openshift/sig-auth