Controller logging #419
Merged
Controller logging #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
Member
|
/approve |
runcom
reviewed
Feb 13, 2019
Member
There was a problem hiding this comment.
# github.com/openshift/machine-config-operator/pkg/controller/node
pkg/controller/node/node_controller.go:383: Infof format %v reads arg #2, but call has 1 arg
pkg/controller/node/status.go:32: Infof format %s has arg newPool.Status of wrong type github.com/openshift/machine-config-operator/pkg/apis/machineconfiguration.openshift.io/v1.MachineConfigPoolStatus
Member
Author
There was a problem hiding this comment.
OK I dropped the status patch, did that at the last second and hadn't tested it. Doing that "right" is probably changing the operator to do the logging, as it already has the code to render things to a string.
A pool may not be configured on initial cluster bringup. Let's not spam the logs about it. It's also not an error.
So an admin can look at the logs and see progress there.
cgwalters
force-pushed
the
controller-logging
branch
from
96ed6d0 to
8ea73fb
Compare
Member
/test rhel-images |
Member
Author
|
OK this is passing tests and looks a bit nicer: |
Member
|
/lgtm |
ashcrow
approved these changes
Feb 13, 2019
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
|
Router related /test e2e-aws |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few patches for the node controller to help me debug #385