daemon/update: Log each error before retrying

[jlebon]

That way, we get more feedback when retrying since it can take a while.
And we also catch the instance when e.g. different errors might have
happened each time.

[cgwalters]

/lgtm

But...I think the real fix here is something like #410 where all of the fiddly details of "retry in a loop" are codified and consistent.

[runcom]

could you also fix the formatting some lines below:

			return errors.Wrapf(lastErr, "Failed to drain node (%s tries)", backoff.Steps)

it should be %d as backoff.Steps is an int, not a string

[ashcrow]

/hold

Per @runcom's comment.

[ashcrow]

Looks good as is, but there was a request for update.

[runcom]

Looks good as is, but there was a request for update.

a really nit(y) one lol sorry for that

[jlebon]

it should be %d as backoff.Steps is an int, not a string

Fixed!

[runcom]

/lgtm

[ashcrow]

/hold cancel

[ashcrow]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, jlebon, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ashcrow,cgwalters,jlebon,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.