Skip to content

OCPBUGS-15463: Minor fix to support protectKernelDefaults field in Kubelet Config #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 3, 2023
Merged

OCPBUGS-15463: Minor fix to support protectKernelDefaults field in Kubelet Config #3757

openshift-merge-robot merged 1 commit into from
Jul 3, 2023

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 26, 2023

This is an automated cherry-pick of #3736

/assign sairameshv

@sairameshv
Minor fix to support protectKernelDefaults field in Kubelet Config
1de6d18 
`protectKernelDefaults` field is an upstream, optional boolean field in the Kubelet Configuration
Recently, this has been defaulted to `true` in the OCP
So, even if the user inputs the field to `false`, this gets omitted due to the tag
Added a minor workaround to detect if the user has set the field to `false`

Signed-off-by: Sai Ramesh Vanka <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 26, 2023
Merged
@openshift-ci openshift-ci bot requested review from jkyros and yuqi-zhang June 26, 2023 15:06
@sairameshv
Copy link
Member

sairameshv commented Jun 27, 2023

/retest

sinnykumari
sinnykumari approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean backport

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@sunilcio
Copy link

sunilcio commented Jun 27, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 27, 2023
@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 27, 2023
@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 27, 2023

@rphillips: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/retitle OCPBUGS-14399: Minor fix to support protectKernelDefaults field in Kubelet Config

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-14399 : Minor fix to support protectKernelDefaults field in Kubelet Config OCPBUGS-14399: Minor fix to support protectKernelDefaults field in Kubelet Config Jun 27, 2023
@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 27, 2023

@rphillips: Jira Issue OCPBUGS-14399 is in a security level that is not in the allowed security levels for this repo.
Allowed security levels for this repo are:

  • Red Hat Employee
  • default
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 27, 2023

@rphillips: This pull request references Jira Issue OCPBUGS-14399, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead
  • expected Jira Issue OCPBUGS-14399 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/retitle OCPBUGS-15463: Minor fix to support protectKernelDefaults field in Kubelet Config

@openshift-ci openshift-ci bot changed the title OCPBUGS-14399: Minor fix to support protectKernelDefaults field in Kubelet Config OCPBUGS-15463: Minor fix to support protectKernelDefaults field in Kubelet Config Jun 27, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 27, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15463, which is invalid:

  • expected Jira Issue OCPBUGS-15463 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #3736

/assign sairameshv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 27, 2023

@rphillips: This pull request references Jira Issue OCPBUGS-15463, which is invalid:

  • expected dependent Jira Issue OCPBUGS-14399 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

rphillips commented Jun 27, 2023

14399 needs to be verified by QE.

@sairameshv
Copy link
Member

sairameshv commented Jul 3, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2023

@sairameshv: This pull request references Jira Issue OCPBUGS-15463, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14399 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-14399 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 305c495 into openshift:release-4.13 Jul 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15463: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15463 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #3736

/assign sairameshv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@jkyros jkyros Awaiting requested review from jkyros

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@rbbratta rbbratta

@eurijon eurijon

@sairameshv sairameshv

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.