[release-4.12] OCPBUGS-9993: Revert "daemon: Temporarily copy auth file with more open perms on FCOS" #3608

vrutkovs · 2023-03-11T09:25:02Z

This reverts commit 6ccdd57. Cherry-pick of #3594 on release-4.12 branch

- What I did
Reverted one of commits introduced in #3358 to fix OKD-63. This workaround however breaks Assisted Installer flow, which runs mcd start on Live ISO where /var/lib/kubelet/config.json is not yet created.

- How to verify it
Install OKD FCOS/SCOS

- Description for the changelog

This reverts commit 6ccdd57.

openshift-ci · 2023-03-11T09:25:05Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2023-03-11T09:25:11Z

/jira cherrypick OCPBUGS-8523

openshift-ci-robot · 2023-03-11T09:25:21Z

@vrutkovs: Jira Issue OCPBUGS-8523 has been cloned as Jira Issue OCPBUGS-9992. Will retitle bug to link to clone.
/retitle OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Details

In response to this:

/jira cherrypick OCPBUGS-8523

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-11T09:25:28Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-11T09:25:29Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-9992, which is invalid:

expected dependent Jira Issue OCPBUGS-8523 to target a version in 4.13.0, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit 6ccdd57. Cherry-pick of #3594 on release-4.12 branch

What I did
Reverted one of commits introduced in MCO-396: daemon: FCOS workaround, plus SELinux workaround #3358 to fix OKD-63. This workaround however breaks Assisted Installer flow, which runs mcd start on Live ISO where /var/lib/kubelet/config.json is not yet created.

How to verify it
Install OKD FCOS/SCOS

Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-11T09:25:40Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-11T09:25:41Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-9992, which is invalid:

expected dependent Jira Issue OCPBUGS-8523 to target a version in 4.13.0, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This reverts commit 6ccdd57. Cherry-pick of #3594 on release-4.12 branch

- What I did
Reverted one of commits introduced in #3358 to fix OKD-63. This workaround however breaks Assisted Installer flow, which runs mcd start on Live ISO where /var/lib/kubelet/config.json is not yet created.

- How to verify it
Install OKD FCOS/SCOS

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2023-03-11T09:27:42Z

/jira cherrypick OCPBUGS-8702

openshift-ci-robot · 2023-03-11T09:27:51Z

@vrutkovs: Jira Issue OCPBUGS-8702 has been cloned as Jira Issue OCPBUGS-9993. Will retitle bug to link to clone.
/retitle OCPBUGS-9993: OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Details

In response to this:

/jira cherrypick OCPBUGS-8702

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-11T09:27:56Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-9993: OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-11T09:27:57Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-9993, which is invalid:

expected dependent Jira Issue OCPBUGS-8702 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit 6ccdd57. Cherry-pick of #3594 on release-4.12 branch

- What I did
Reverted one of commits introduced in #3358 to fix OKD-63. This workaround however breaks Assisted Installer flow, which runs mcd start on Live ISO where /var/lib/kubelet/config.json is not yet created.

- How to verify it
Install OKD FCOS/SCOS

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2023-03-11T09:28:16Z

/retitle [release-4.12] OCPBUGS-9993: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

openshift-ci · 2023-03-11T09:28:20Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-9993: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2023-03-11T09:28:53Z

/jira refresh

openshift-ci-robot · 2023-03-11T09:28:56Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-9993, which is invalid:

expected dependent Jira Issue OCPBUGS-8702 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sinnykumari · 2023-03-13T14:41:30Z

/jira refresh

openshift-ci-robot · 2023-03-13T14:41:54Z

@sinnykumari: This pull request references Jira Issue OCPBUGS-9993, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-8702 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-8702 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @rioliu-rh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sinnykumari

Clean backport and changes made is specific to SCOS and FCOS

sinnykumari · 2023-03-13T14:47:32Z

/lgtm
/label backport-risk-assessed

openshift-ci · 2023-03-13T14:59:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-03-13T15:01:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rioliu-rh · 2023-03-13T15:03:22Z

/label cherry-pick-approved

openshift-ci-robot · 2023-03-13T15:13:19Z

/retest-required

Remaining retests: 0 against base HEAD 15741d4 and 2 for PR HEAD 6f14b0c in total

vrutkovs · 2023-03-14T08:57:43Z

/test e2e-aws

vrutkovs · 2023-03-14T16:53:16Z

/refresh

openshift-ci · 2023-03-14T16:53:51Z

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn	`6f14b0c`	link	false	`/test okd-scos-e2e-vsphere-ovn`
ci/prow/e2e-hypershift	`6f14b0c`	link	false	`/test e2e-hypershift`
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	`6f14b0c`	link	false	`/test okd-scos-e2e-gcp-ovn-upgrade`
ci/prow/okd-scos-e2e-aws-ovn	`6f14b0c`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs · 2023-03-14T16:54:01Z

/retest-required

openshift-ci-robot · 2023-03-14T19:04:12Z

@vrutkovs: Jira Issue OCPBUGS-9993: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#3608

Jira Issue OCPBUGS-9993 has been moved to the MODIFIED state.

Details

In response to this:

This reverts commit 6ccdd57. Cherry-pick of #3594 on release-4.12 branch

- What I did
Reverted one of commits introduced in #3358 to fix OKD-63. This workaround however breaks Assisted Installer flow, which runs mcd start on Live ISO where /var/lib/kubelet/config.json is not yet created.

- How to verify it
Install OKD FCOS/SCOS

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Revert "daemon: Temporarily copy auth file with more open perms on FCOS"

6f14b0c

This reverts commit 6ccdd57.

openshift-ci bot changed the title ~~Revert "daemon: Temporarily copy auth file with more open perms on FCOS"~~ OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS" Mar 11, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 11, 2023

openshift-ci bot requested review from jkyros and yuqi-zhang March 11, 2023 09:25

openshift-ci bot changed the title ~~OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"~~ OCPBUGS-9993: OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS" Mar 11, 2023

openshift-ci bot changed the title ~~OCPBUGS-9993: OCPBUGS-9992: Revert "daemon: Temporarily copy auth file with more open perms on FCOS"~~ [release-4.12] OCPBUGS-9993: Revert "daemon: Temporarily copy auth file with more open perms on FCOS" Mar 11, 2023

openshift-ci bot requested a review from rioliu-rh March 13, 2023 14:42

sinnykumari approved these changes Mar 13, 2023

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 13, 2023

openshift-ci bot assigned anuragthehatter, eurijon, mburman5, mhanss, rbbratta, reihl, rioliu-rh, sergiordlr, sunilcio and sinnykumari Mar 13, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 13, 2023

openshift-merge-robot merged commit 731341b into openshift:release-4.12 Mar 14, 2023

[release-4.12] OCPBUGS-9993: Revert "daemon: Temporarily copy auth file with more open perms on FCOS" #3608

[release-4.12] OCPBUGS-9993: Revert "daemon: Temporarily copy auth file with more open perms on FCOS" #3608

Uh oh!

Conversation

vrutkovs commented Mar 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 11, 2023

Uh oh!

vrutkovs commented Mar 11, 2023

Uh oh!

openshift-ci-robot commented Mar 11, 2023

Uh oh!

openshift-ci bot commented Mar 11, 2023

Uh oh!

openshift-ci-robot commented Mar 11, 2023

Uh oh!

openshift-ci bot commented Mar 11, 2023

Uh oh!

openshift-ci-robot commented Mar 11, 2023

Uh oh!

vrutkovs commented Mar 11, 2023

Uh oh!

openshift-ci-robot commented Mar 11, 2023

Uh oh!

openshift-ci bot commented Mar 11, 2023

Uh oh!

openshift-ci-robot commented Mar 11, 2023

Uh oh!

vrutkovs commented Mar 11, 2023

Uh oh!

openshift-ci bot commented Mar 11, 2023

Uh oh!

vrutkovs commented Mar 11, 2023

Uh oh!

openshift-ci-robot commented Mar 11, 2023

Uh oh!

sinnykumari commented Mar 13, 2023

Uh oh!

openshift-ci-robot commented Mar 13, 2023

Uh oh!

sinnykumari left a comment

Choose a reason for hiding this comment

Uh oh!

sinnykumari commented Mar 13, 2023

Uh oh!

openshift-ci bot commented Mar 13, 2023

Uh oh!

openshift-ci bot commented Mar 13, 2023

Uh oh!

rioliu-rh commented Mar 13, 2023

Uh oh!

openshift-ci-robot commented Mar 13, 2023

Uh oh!

vrutkovs commented Mar 14, 2023

Uh oh!

vrutkovs commented Mar 14, 2023

Uh oh!

openshift-ci bot commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrutkovs commented Mar 14, 2023

Uh oh!

openshift-ci-robot commented Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

vrutkovs commented Mar 11, 2023 •

edited

Loading

openshift-ci bot commented Mar 14, 2023 •

edited

Loading