-
Notifications
You must be signed in to change notification settings - Fork 462
Config Drift Monitor should alert on unexpected SSH key changes #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config Drift Monitor should alert on unexpected SSH key changes #3538
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cheesesashimi Looks like this will also solve, https://issues.redhat.com/browse/MCO-435. Does that sounds correct? |
c20025f to
59b01c0
Compare
59b01c0 to
0dbd157
Compare
Yes, this should fix that one as well. |
|
/test unit |
|
/test unit |
d75802b to
d467d81
Compare
|
/test unit |
1 similar comment
|
/test unit |
a794dda to
7c8c61e
Compare
7c8c61e to
52e3975
Compare
52e3975 to
7fa099d
Compare
|
/test unit |
2 similar comments
|
/test unit |
|
/test unit |
595c20c to
b54f305
Compare
b54f305 to
b1f6747
Compare
|
/test unit |
|
/test unit |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I plan to pare this PR down in both scope and complexity by breaking up the refactoring into separate PRs so that this can be focused solely on what's needed to make Config Drift Monitor aware of SSH keys. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
@cheesesashimi: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- What I did
The Config Drift Monitor should listen for mutations to the SSH key files. Additionally, in the case of RHCOS 8 -> RHCOS 9, it should alert if an SSH key was written to the old path.
- How to verify it
/home/core/.ssh/authorized_keysfor RHCOS 8,/home/core/.ssh/authorized_keys.d/ignitionfor RHCOS 9). The node should drift.- Description for the changelog
Config Drift Monitor watches for mutations to SSH key files