Add doc for IDMS and ITMS CRDs #3530
Conversation
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
Overall lgtm, thanks for the docs!
Some nits below:
QiWang19
force-pushed
the
crddocs
branch
2 times, most recently
from
ac85097 to
d7101de
Compare
|
@yuqi-zhang PTAL |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
generally lgtm, thanks! one last spelling change
openshift-ci
bot
added
the
approved
Follow up the PR: openshift#3037 Add the document to give examples of the new mirror configuration CRDs ImageDigestMirrorSet and ImageTagMirrorSet. Signed-off-by: Qi Wang <[email protected]>
|
@yuqi-zhang PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Signed-off-by: Qi Wang [email protected]
- What I did
Follow up the PR: #3037
Add the document to give examples of the new mirror configuration CRDs ImageDigestMirrorSet and ImageTagMirrorSet.
- How to verify it
- Description for the changelog
Add document for ImageDigestMirrorSet and ImageTagMirrorSet.