operator: Add bootstrap arg --osimg-config-file

[cgwalters]

This will allow the installer to render the payload's osImageURL
ConfigMap in the initial MachineConfig as well.

Closes: #334

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

can you open an installer PR that shows how this will be used, i don't see how you will extract the os-image-url config file from release image.

[cgwalters]

OK we just had a realtime meeting about this; the main central point was around parsing the ConfigMap.

The command mentioned above works to get the osimageurl, so we could clearly pass this down directly:

podman run --rm registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-29-202701 image machine-os-content
registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-01-29-202701@sha256:61dc83d62cfb5054c4c5532bd2478742a0711075ef5151572e63f94babeacc1a

However, as I understood things the release payload must literally contain the files we have in our install/ directory as the CVO creates it. And indeed:

# podman run -ti --rm --entrypoint cat registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-29-202701 /release-manifests/0000_30_machine-config-operator_05_osimageurl.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: machine-config-osimageurl
  namespace: openshift-machine-config-operator
data:
  # The OS payload, managed by the daemon + pivot + rpm-ostree
  # https://github.com/openshift/machine-config-operator/issues/183
  osImageURL: "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-01-29-202701@sha256:61dc83d62cfb5054c4c5532bd2478742a0711075ef5151572e63f94babeacc1a"

So I guess one thing I don't quite understand...why in bootkube.sh don't we just pass the bootstrap command for the MCO literally the extracted path to /release-manifests and just look in that directory for our own manifests? Then we could e.g. give the images.json directly.

And here we clearly could pass the configmap as well right?

[cgwalters]

Closing in favor of #355