Skip to content

controller: allow using the images from release-image #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Jan 31, 2019
Merged

controller: allow using the images from release-image #343

openshift-merge-robot merged 5 commits into from
Jan 31, 2019

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Jan 24, 2019 •
edited
Loading

Currently the controller is using fixed images for containers in machineconfigs. This allows the release pipeline to drive the images using the operator.

/cc @cgwalters

@abhinavdahiya
apis: add images to controllerconfig
ae62054 
the `template` controller needs to allow for customization for images it uses in generated machineconfigs.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2019
@cgwalters
Copy link
Member

cgwalters commented Jan 25, 2019

Seems sane to me, I just want to quickly check: this should go in because any images not part of the release payload are a release blocker right?

@ashcrow
Copy link
Member

ashcrow commented Jan 26, 2019

/retest

@ashcrow
Copy link
Member

ashcrow commented Jan 26, 2019 

level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

/retest

@ashcrow
Copy link
Member

ashcrow commented Jan 26, 2019

/retest

1 similar comment
@ashcrow
Copy link
Member

ashcrow commented Jan 26, 2019

/retest

@cgwalters
Copy link
Member

cgwalters commented Jan 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

jlebon
jlebon reviewed Jan 29, 2019
View reviewed changes
templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml Outdated
Copy link
Member

@jlebon jlebon Jan 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be .Images.etcd ?

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Jan 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with 7d9f48b

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Member

cgwalters commented Jan 29, 2019

/lgtm cancel
based on #343 (comment)

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@jlebon
Copy link
Member

jlebon commented Jan 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 30, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@jlebon jlebon mentioned this pull request Jan 30, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 30, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 30, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya
cmd: allow image flags to override image from images-configmap
6f0f3ff 
Currently you can either specify `images-configmap` or you need to set all images using the corresponding image flag. This makes it difficult
to add new images like `etcd, setupEtcdEnv` as these are not set in installer [1] yet. This allows MCO to add new images with deafults and then update installer to override them
from the release image during bootstrapping.

[1]: https://github.com/openshift/installer/blob/d3ff3afe836d9880610a14be2f00d86ed34f3a13/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template#L129-L131
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2019
@jlebon
Copy link
Member

jlebon commented Jan 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@ashcrow
Copy link
Member

ashcrow commented Jan 31, 2019

/test e2e-aws

@ashcrow
Copy link
Member

ashcrow commented Jan 31, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 71ace53 into openshift:master Jan 31, 2019
@cgwalters cgwalters mentioned this pull request Feb 5, 2019
Closed
@cgwalters cgwalters mentioned this pull request Feb 21, 2019
Closed
@cgwalters
Copy link
Member

cgwalters commented Feb 21, 2019

This required openshift/installer#1194 as a followup.

osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
@openshift-merge-robot
Merge pull request openshift#343 from cfergeau/single-node-developer
6e02b3c 
Annotate manifests for single-node-developer cluster profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlebon jlebon jlebon left review comments

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@cgwalters cgwalters

@jlebon jlebon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@abhinavdahiya @cgwalters @ashcrow @openshift-bot @jlebon @openshift-ci-robot @openshift-merge-robot