controller/node: Also add a 5s delay here responding to pool changes #337
Conversation
This is like openshift#303 but for the node controller. We really don't need to react *instantly* to start updating and rebooting machines, and having a small delay will help avoid races when MCs are created rapidly.
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
Testing this now. |
|
Look at the logs here for an example of this: There the node controller tried to sync 15-16 times in the span of 3 seconds. |
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
Tested on a cluster and applied a new config, did not see "Error syncing machineconfigpool" this time around.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note this is a partial fix for Issue #338 |
|
/test e2e-aws |
|
/retest |
…penshift-4.7-ose-cluster-samples-operator Updating ose-cluster-samples-operator builder & base images to be consistent with ART
5 participants
This is like
#303
but for the node controller.
We really don't need to react instantly to start updating and
rebooting machines, and having a small delay will help avoid
races when MCs are created rapidly.