daemon: Drop mock node updater client #3325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea of unit testing things is laudable. We've been carrying around this "NodeUpdaterClient" abstraction for a long time that tries to abstract over rpm-ostree as well as having a dummy/mock backend for unit tests. The unit test case...never really did much. The code has *tons* of direct calls to rpm-ostree. Fully mocking all of that out would be possible, but has never been done. I don't think doing that mocking is worth it versus having efficient end-to-end testing in a real environment. Drop it, in preparation for fully dropping the `NodeUpdaterClient` abstraction API in favor of direct calls to https://github.com/cgwalters/rpmostree-client-go
openshift-ci
bot
added
the
approved
Contributor
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
+1 for this cleanup |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of unit testing things is laudable. We've been carrying around this "NodeUpdaterClient" abstraction for a long time that tries to abstract over rpm-ostree as well as having a dummy/mock backend for unit tests.
The unit test case...never really did much. The code has tons of direct calls to rpm-ostree. Fully mocking all of that out would be possible, but has never been done.
I don't think doing that mocking is worth it versus having efficient end-to-end testing in a real environment.
Drop it, in preparation for fully dropping the
NodeUpdaterClientabstraction API in favor of direct calls tohttps://github.com/cgwalters/rpmostree-client-go