Skip to content

Conversation

@cgwalters
Copy link
Member

go.mod: Unpin k8s.io bits

Prep for bumping openshift/library-go.


go.mod: Remove pinned googleapis/gnostic

Prep for bumping openshift/client-go.


Prep for bumping openshift/library-go.
Prep for bumping openshift/client-go.
@openshift-ci openshift-ci bot requested review from jkyros and yuqi-zhang July 14, 2022 21:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@cgwalters
Copy link
Member Author

/retest

1 similar comment
@jkyros
Copy link
Member

jkyros commented Jul 15, 2022

/retest

@cgwalters
Copy link
Member Author

We're seeing everything just be slightly slower here...
/retest

@cgwalters
Copy link
Member Author

@yuqi-zhang noticed this odd one minute gap:

I0715 22:21:52.567143    1770 update.go:2007] Running: rpm-ostree cleanup -r
Deployments unchanged.
I0715 22:22:54.422596    1770 update.go:2022] Disk currentConfig rendered-infra-676895678d7aae6bdfda04a7e194bd39 overrides node's currentConfig annotation rendered-infra-7298ec050960e770130244494d5d44c5

@cgwalters
Copy link
Member Author

/retest

1 similar comment
@cgwalters
Copy link
Member Author

/retest

@jkyros
Copy link
Member

jkyros commented Jul 20, 2022

I did glance through those test runs. Am I correct in interpreting the above as

  • "the tests were probably slow because of unrelated issues and everything is probably fine"

rather than

  • "The library bump seems to have made the MCO noticably slower? "

😄

@cgwalters
Copy link
Member Author

I'm not sure honestly. Offhand, I think our e2e-gcp-op may have actually been suffering from openshift/os#898 which got fixed.

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e70b60f into openshift:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants