-
Notifications
You must be signed in to change notification settings - Fork 463
Prep patches for bumping openshift/client-go #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep patches for bumping openshift/client-go #3251
Conversation
Prep for bumping openshift/library-go.
Prep for bumping openshift/client-go.
|
/retest |
1 similar comment
|
/retest |
|
We're seeing everything just be slightly slower here... |
|
@yuqi-zhang noticed this odd one minute gap: |
|
/retest |
1 similar comment
|
/retest |
|
I did glance through those test runs. Am I correct in interpreting the above as
rather than
😄 |
|
I'm not sure honestly. Offhand, I think our e2e-gcp-op may have actually been suffering from openshift/os#898 which got fixed. |
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so the slowdown seems to have gone away with the aforementioned fixes in openshift/os#898. Now cleanup or not the delay is generally very small:
and
Otherwise, this looks like a clean bump, all CI is happy, let's get this in!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
go.mod: Unpin k8s.io bits
Prep for bumping openshift/library-go.
go.mod: Remove pinned googleapis/gnostic
Prep for bumping openshift/client-go.