[4.11] Bug 2102633: NS manifest: Set empty openshift.io/run-level

[stlaz]

We dropped the run-level label from this namespace back in 4.5
but because of how the cluster-version operator reconciles manifest
labels, dropping a label from the manifest does not remove it from the
in-cluster resource when old clusters are updated into the new
manifest. This commit uses the approach the cluster-version
operator used to drop its run-level, by setting the value to an
empty string, which the run-level-consuming code treats identically to
an unset label.

This avoids errors about:

...container has runAsNonRoot and image will run as root...

when updating to 4.11 in case the operator deployment manifest
specifically requests runAsNonRoot: true.

[openshift-ci]

@stlaz: This pull request references Bugzilla bug 2102633, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
• expected dependent Bugzilla bug 2101880 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
• expected dependent Bugzilla bug 2102834 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
• expected dependent Bugzilla bug 2102834 to target a release in 4.12.0, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[4.11] Bug 2102633: NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@stlaz: This pull request references Bugzilla bug 2102633, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
• expected dependent Bugzilla bug 2101880 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
• expected dependent Bugzilla bug 2102834 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
• expected dependent Bugzilla bug 2102834 to target a release in 4.12.0, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[4.11] Bug 2102633: NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-upgrade	9cac0e8	link	false	/test e2e-vsphere-upgrade
ci/prow/e2e-aws-upgrade-single-node	9cac0e8	link	false	/test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-single-node	9cac0e8	link	false	/test e2e-aws-single-node
ci/prow/e2e-aws-disruptive	9cac0e8	link	false	/test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sinnykumari]

Backported from #3218

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stlaz]

handled by #3221

[openshift-ci]

@stlaz: An error was encountered removing this pull request from the external tracker bugs for bug 2102633 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[4.11] Bug 2102633: NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.