Skip to content

[release-4.10] Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 28, 2022
Merged

[release-4.10] Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc #3091

openshift-merge-robot merged 1 commit into from
Apr 28, 2022

Conversation

@ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Apr 18, 2022

Manually picking commits from #3064
- What I did

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2022

@ravisantoshgudimetla: This pull request references Bugzilla bug 2035005, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "4.11.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 2035005 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2035005: Move removeUpdateInProgressTaint functionality to mcc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravisantoshgudimetla ravisantoshgudimetla changed the title Bug 2035005: Move removeUpdateInProgressTaint functionality to mcc Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc Apr 18, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Apr 18, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2022

@ravisantoshgudimetla: This pull request references Bugzilla bug 2076308, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2035005 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2035005 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2022

@ravisantoshgudimetla: This pull request references Bugzilla bug 2076308, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2035005 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2035005 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rioliu-rh
Copy link

rioliu-rh commented Apr 22, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 22, 2022
@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Apr 22, 2022

/test bootstrap-unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

@yuqi-zhang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.10-upgrade-from-stable-4.9-images
  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-gcp-op
  • /test images
  • /test okd-images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade
  • /test bootstrap-unit
  • /test e2e-aws-disruptive
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-ovn-upgrade
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-config-operator-release-4.10-4.10-upgrade-from-stable-4.9-images
  • pull-ci-openshift-machine-config-operator-release-4.10-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-ovn-workers-rhel8
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-single-node
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-upgrade-single-node
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-aws-workers-rhel8
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-release-4.10-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.10-images
  • pull-ci-openshift-machine-config-operator-release-4.10-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.10-okd-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.10-okd-e2e-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.10-okd-images
  • pull-ci-openshift-machine-config-operator-release-4.10-unit
  • pull-ci-openshift-machine-config-operator-release-4.10-verify
Details

In response to this:

/test ci/prow/bootstrap-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang
yuqi-zhang approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure for bootstrap-unit is due to #3008

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2022
@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Apr 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice kikisdeliveryservice changed the title Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc [release-4.10] Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc Apr 27, 2022
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 27, 2022

/test e2e-agnostic-upgrade
/test e2e-vsphere-upgrade
/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Apr 28, 2022

I've looked at some failures in the e2e and they appear to be various flakes. I checked some logs and there are no indications of MCO failures due to this change. Going to override this as it is a backport, and we don't want to just waste resources on this constantly failing test.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

I've looked at some failures in the e2e and they appear to be various flakes. I checked some logs and there are no indications of MCO failures due to this change. Going to override this as it is a backport, and we don't want to just waste resources on this constantly failing test.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@ravisantoshgudimetla: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-single-node d7c5cf7 link false /test e2e-aws-upgrade-single-node
ci/prow/okd-e2e-gcp-op d7c5cf7 link false /test okd-e2e-gcp-op
ci/prow/e2e-aws-single-node d7c5cf7 link false /test e2e-aws-single-node
ci/prow/e2e-aws-disruptive d7c5cf7 link false /test e2e-aws-disruptive
ci/prow/bootstrap-unit d7c5cf7 link false /test bootstrap-unit
ci/prow/e2e-vsphere-upgrade d7c5cf7 link false /test e2e-vsphere-upgrade
ci/prow/e2e-agnostic-upgrade d7c5cf7 link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7e4fe18 into openshift:release-4.10 Apr 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

@ravisantoshgudimetla: All pull requests linked via external trackers have merged:

Bugzilla bug 2076308 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.10] Bug 2076308: Move removeUpdateInProgressTaint functionality to mcc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@yuqi-zhang yuqi-zhang

Labels

4.10 approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ravisantoshgudimetla @rioliu-rh @yuqi-zhang @openshift-bot @kikisdeliveryservice @openshift-merge-robot