Create MCONamespace constant

[mkenigs]

Created MCONamespace constant and used in all *.go files except for
test/helpers/utils.go which would create a cyclic import

Pulling out of #2987
Can't reopen #2982

[kikisdeliveryservice]

would a nolint:gocyclo solve the utils issue? for ex: 0c55518

[mkenigs]

I think it's a compilation issue not a linting issue:

$ make test-unit
CGO_ENABLED=0 go test -tags="containers_image_openpgp exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_ostree_stub" -count=1 -v ./cmd/... ./pkg/... ./lib/...
# github.com/openshift/machine-config-operator/pkg/controller/common
package github.com/openshift/machine-config-operator/pkg/controller/common
	imports github.com/openshift/machine-config-operator/test/helpers: import cycle not allowed in test

[mkenigs]

Didn't look into eliminating the cycle

[kikisdeliveryservice]

Gotcha 👍

/approve

[kikisdeliveryservice]

Didn't look into eliminating the cycle

My suggestion was bogus (i tested) 😆 - the cycle is bc:
controller/common/helpers_test.go imports "github.com/openshift/machine-config-operator/test/helpers"

so imo it's fine as is.

[kikisdeliveryservice]

/cherry-pick master

[openshift-cherrypick-robot]

@kikisdeliveryservice: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

/test e2e-gcp-op
/test e2e-agnostic-upgrade

[cgwalters]

Overall looks sane to me but will defer final lgtm to @kikisdeliveryservice since she did more review.

[openshift-ci]

@mkenigs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-single-node	abda106	link	false	/test e2e-gcp-op-single-node
ci/prow/e2e-agnostic-upgrade	2472296152ebe99a58b587ce8ca7abd0160b0aa7	link	true	/test e2e-agnostic-upgrade
ci/prow/e2e-gcp-op	2472296152ebe99a58b587ce8ca7abd0160b0aa7	link	true	/test e2e-gcp-op
ci/prow/e2e-aws-upgrade	abda106	link	false	/test e2e-aws-upgrade
ci/prow/e2e-gcp-single-node	abda106	link	false	/test e2e-gcp-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kikisdeliveryservice]

ok let's try our new cherrypicking process!

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, mkenigs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@kikisdeliveryservice: new pull request created: #3025

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.