Preparatory patches for bumping fcct -> butane #2980
Conversation
Prep for further patches to use butane.
We have other various places that are directly trying to do this, and will fail if files are compressed. (This function should probably be upstreamed into Ignition actually)
This way they all correctly handle compression. Will be needed for a further patch which will use butane, which seems to use compression by default.
openshift-ci
bot
added
the
approved
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
looks clean to me, just small q/comment
Came up in review, but these are far from the only thing.
|
/retest-required |
|
This looks good - straightforward and clean 👍 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
OK I don't quite understand what's going on in the upgrade tests, but I have a theory that this is somehow related to us changing the Ignition templates, which will cause all nodes to drain/reboot, including the control plane. Other PRs that don't change the templates wouldn't cause that. But...hmm, it is surprisingly painful to piece together the picture of upgrades. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
We are having a chat re e2e-agnostic-upgrade reliability, some points:
BZs: |
4 participants
Prep patches for #2976
--
controller: Add unit test for built-in templating
Prep for further patches to use butane.
Move helper to read Ignition file contents into controller/common
We have other various places that are directly trying to do this,
and will fail if files are compressed.
(This function should probably be upstreamed into Ignition actually)
controller: Convert all things reading files from Ignition to use helper
This way they all correctly handle compression.
Will be needed for a further patch which will use butane, which seems
to use compression by default.