templates: Clean out filesystem properties #2894
Conversation
The `filesystem: "root"` kv pair is a remnant of the past from when the template format was based on the Container Linux Config spec. Nowadays, it's based on the Butane config spec (formerly known as Fedora CoreOS Config) where this property node does not exist, and is thus ignored when transpiling templates to Ignition config.
|
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
For ref, filesystem: was removed in most of the templates long ago via : #1678
Thanks @LorbusChris !
openshift-ci
bot
added
the
approved
|
friendly ping :) |
|
/skip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 participants
The
filesystem: "root"kv pair is a remnant of the past from whenthe template format was based on the Container Linux Config spec.
Nowadays, it's based on the Butane config spec (formerly known as
Fedora CoreOS Config) where this property node does not exist, and is
thus ignored when transpiling templates to Ignition config.