Skip to content

updates docs for config drift detection #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 9, 2022
Merged

updates docs for config drift detection #2872

openshift-merge-robot merged 1 commit into from
Feb 9, 2022

Conversation

@cheesesashimi
Copy link
Member

@cheesesashimi cheesesashimi commented Dec 14, 2021

- What I did

Adds docs for the config drift detection mechanism introduced by #2795

- How to verify it

- Description for the changelog

Adds docs for config drift detection

@cheesesashimi
Copy link
Member Author

cheesesashimi commented Dec 15, 2021

/label retest-not-required-docs-only

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@cheesesashimi: The label(s) /label retest-not-required-docs-only cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

Details

In response to this:

/label retest-not-required-docs-only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkenigs
mkenigs suggested changes Dec 16, 2021
View reviewed changes
@cheesesashimi cheesesashimi force-pushed the zzlotnik/config-drift-doc-update branch from 2d6bebe to 7f05c05 Compare December 16, 2021 22:05
yuqi-zhang
yuqi-zhang reviewed Dec 16, 2021
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, one comment below

@cheesesashimi cheesesashimi force-pushed the zzlotnik/config-drift-doc-update branch 2 times, most recently from 0381b1d to 091c583 Compare December 17, 2021 18:28
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Dec 21, 2021

/skip

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Dec 21, 2021

This is doc change doesn't need these run.. we updated release repo so hopefully they won't run again.

/override ci/prow/e2e-aws-gcp-op
/override ci/prow/e2e-aws
/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@kikisdeliveryservice: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-aws-gcp-op

Only the following contexts were expected:

  • ci/prow/bootstrap-unit
  • ci/prow/e2e-agnostic-upgrade
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-single-node
  • ci/prow/e2e-aws-workers-rhel8
  • ci/prow/e2e-gcp-op
  • ci/prow/okd-images
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-machine-config-operator-fcos-e2e-aws
  • pull-ci-openshift-machine-config-operator-fcos-unit
  • pull-ci-openshift-machine-config-operator-fcos-verify
  • pull-ci-openshift-machine-config-operator-master-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel8
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • tide
Details

In response to this:

This is doc change doesn't need these run.. we updated release repo so hopefully they won't run again.

/override ci/prow/e2e-aws-gcp-op
/override ci/prow/e2e-aws
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice
kikisdeliveryservice reviewed Dec 21, 2021
View reviewed changes
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jan 4, 2022

@cheesesashimi when you get a chance can you update with the outstanding change so we can get this merged? :D

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 8, 2022

@cheesesashimi when you get a chance can you pick up the last changes and rebase?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2022
@cheesesashimi cheesesashimi force-pushed the zzlotnik/config-drift-doc-update branch from 091c583 to c57191e Compare February 9, 2022 22:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022 •
edited
Loading

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 091c58393840bce715f662e0b71c6f45b5d22003 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-single-node 091c58393840bce715f662e0b71c6f45b5d22003 link false /test e2e-aws-single-node
ci/prow/e2e-agnostic-upgrade 091c58393840bce715f662e0b71c6f45b5d22003 link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cheesesashimi cheesesashimi force-pushed the zzlotnik/config-drift-doc-update branch from c57191e to d60da15 Compare February 9, 2022 22:42
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2022
@cheesesashimi cheesesashimi force-pushed the zzlotnik/config-drift-doc-update branch from d60da15 to 136aa7d Compare February 9, 2022 22:43
@cheesesashimi
Copy link
Member Author

cheesesashimi commented Feb 9, 2022

I've rebased. Sorry for the delay!

kikisdeliveryservice
kikisdeliveryservice approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get this in!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9629f56 into openshift:master Feb 9, 2022
@cheesesashimi cheesesashimi deleted the zzlotnik/config-drift-doc-update branch February 9, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang left review comments

+2 more reviewers

@mkenigs mkenigs mkenigs requested changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cheesesashimi @kikisdeliveryservice @yuqi-zhang @mkenigs @openshift-merge-robot