Consolidate duplicated code into applyManifests

[mkenigs]

Besides eliminating code duplication, this will allow more easily unit
testing functions that call resourceapply.* functions, which will help
in migrating from using ./lib to library-go

Created a new type manifestPaths to wrap all the arguments needed for
applyManifests

[yuqi-zhang]

The diff view is a bit wonky but I see everything was just abstracted to syncManifests, which makes a lot of sense.

Out of curiosity, are

type manifestPaths struct {
	clusterRoles        []string
	roleBindings        []string
	clusterRoleBindings []string
	serviceAccounts     []string
	secrets             []string
	daemonsets          []string
}

Those specific types consolidated in library-go?

[mkenigs]

No idea if they're in library-go, but I don't expect there's a function that takes those exact arguments. I guess I could also just pass all of them as args to syncManifests rather than creating a struct. Not sure if that would be cleaner

[kikisdeliveryservice]

/assign

[kikisdeliveryservice]

Some comments / questions

[kikisdeliveryservice]

/retest-required

[openshift-ci]

@mkenigs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-upgrade	eeef059	link	false	/test e2e-vsphere-upgrade
ci/prow/okd-e2e-aws	eeef059	link	false	/test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel8	eeef059	link	false	/test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7	eeef059	link	false	/test e2e-aws-workers-rhel7
ci/prow/e2e-aws-disruptive	eeef059	link	false	/test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kikisdeliveryservice]

great job @mkenigs

[kikisdeliveryservice]

Zack, can you give this a once over and I'll leave the final lgtm to you =)
/assign @cheesesashimi

[mkenigs]

@kikisdeliveryservice thanks and thanks for the feedback :)

[cheesesashimi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, kikisdeliveryservice, mkenigs, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment