Skip to content

[OCPNODE-553] Support allowMirrorByTags From config/v1 ImageContentPolicy #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
QiWang19 wants to merge 3 commits into from
Closed

[OCPNODE-553] Support allowMirrorByTags From config/v1 ImageContentPolicy #2755

QiWang19 wants to merge 3 commits into from

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Sep 5, 2021 •
edited
Loading

Signed-off-by: Qi Wang [email protected]

- What I did
Support allowMirrorByTags From config/v1 ImageContentPolicy
REF: https://issues.redhat.com/browse/OCPNODE-553

Depends on the openshift/runtime-utils PR: openshift/runtime-utils#12

- How to verify it
Apply the ImageContentPolicy to a cluster, debug into the node, etc/containers/registries.conf does not set mirror-by-digest-only=true.

apiVersion: config.openshift.io/v1
kind: ImageContentPolicy
metadata:
  name: ubi8repo
spec:
  repositoryDigestMirrors:
  - mirrors:
    - example.io/example/ubi-minimal 
    source: registry.access.redhat.com/ubi8/ubi-minimal
    allowMirrorByTags: true

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2021
@QiWang19 QiWang19 force-pushed the test-v1-icsp branch 3 times, most recently from d1ada06 to 934d2d0 Compare September 16, 2021 15:50
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021
@QiWang19 QiWang19 force-pushed the test-v1-icsp branch 7 times, most recently from 5f1969f to d3eb603 Compare September 29, 2021 03:39
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021
@QiWang19 QiWang19 marked this pull request as draft September 29, 2021 13:04
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021
@QiWang19
Copy link
Member Author

QiWang19 commented Sep 30, 2021

/retest

@QiWang19 QiWang19 changed the title [WIP] Test v1 icsp crd [OCPNODE-553] Support allowMirrorByTags From config/v1 ImageContentPolicy Sep 30, 2021
@QiWang19 QiWang19 mentioned this pull request Sep 30, 2021
Closed
@QiWang19 QiWang19 marked this pull request as ready for review September 30, 2021 18:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2021
@QiWang19 QiWang19 force-pushed the test-v1-icsp branch 2 times, most recently from bc613cd to d5b90b9 Compare October 1, 2021 15:17
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2021
@QiWang19 QiWang19 marked this pull request as draft October 6, 2021 21:15
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@QiWang19: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2021
@QiWang19 QiWang19 closed this Mar 10, 2022
@QiWang19 QiWang19 reopened this Mar 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
To complete the pull request process, please assign kikisdeliveryservice after the PR has been reviewed.
You can assign the PR to them by writing /assign @kikisdeliveryservice in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 8ce574f0921118fca52e616be9343c6702904d28 link true /test unit
ci/prow/verify 8ce574f0921118fca52e616be9343c6702904d28 link true /test verify
ci/prow/e2e-vsphere-upgrade 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-vsphere-upgrade
ci/prow/e2e-aws-techpreview-featuregate 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-techpreview-featuregate
ci/prow/e2e-aws-workers-rhel8 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-workers-rhel8
ci/prow/images 8ce574f0921118fca52e616be9343c6702904d28 link true /test images
ci/prow/e2e-aws-single-node 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-single-node
ci/prow/okd-images 8ce574f0921118fca52e616be9343c6702904d28 link false /test okd-images
ci/prow/e2e-metal-ipi 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-metal-ipi
ci/prow/e2e-aws-disruptive 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-disruptive
ci/prow/okd-e2e-aws 8ce574f0921118fca52e616be9343c6702904d28 link false /test okd-e2e-aws
ci/prow/e2e-aws-upgrade-single-node 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-workers-rhel7 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-gcp-op-single-node 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-gcp-op-single-node
ci/prow/e2e-ovn-step-registry 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-ovn-step-registry
ci/prow/e2e-aws-serial 8ce574f0921118fca52e616be9343c6702904d28 link false /test e2e-aws-serial
ci/prow/e2e-gcp-op 88d9724 link true /test e2e-gcp-op
ci/prow/e2e-agnostic-upgrade 88d9724 link true /test e2e-agnostic-upgrade
ci/prow/e2e-aws 88d9724 link true /test e2e-aws
ci/prow/4.12-upgrade-from-stable-4.11-images 88d9724 link true /test 4.12-upgrade-from-stable-4.11-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiWang19
Copy link
Member Author

QiWang19 commented Apr 5, 2022

Close PR, the allow mirror by tag feature will be implemented by #3037

@QiWang19 QiWang19 closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@QiWang19