-
Notifications
You must be signed in to change notification settings - Fork 462
DO NOT MERGE - Example of doing replacement #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is part of a conversation around #183 |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@cgwalters if you look at https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/258/pull-ci-openshift-machine-config-operator-master-images/488/artifacts/release-latest/release-payload/0000_50_machine-config-operator_02_images.configmap.yaml you can see how the tag openshift/origin-v4.0:machine-image-content was translated to the SHA inside of your manifest. |
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
So in the case of a reference to an image not generate by the CI process, the release operator will simply pull in that image and mirror it into the release payload? |
|
Superceding by #273 /close |
|
@cgwalters: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
handle concurrent metrics_test.go hiccups
Demonstrating how you can have an RHCoS content image (located in namespace
openshiftand image stream tagorigin-v4.0:machine-image-content) and consume it from an operator.@cgwalters