Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Dec 16, 2018

The last consumer was removed by 4cc7988 (#143).

The last consumer was removed by 4cc7988 (server: remove etcd_index
GET param, 2018-10-26, openshift#143).
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7b029f8 into openshift:master Dec 16, 2018
@wking wking deleted the drop-stale-etcd-param branch December 17, 2018 05:08
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
manifests: add openshift/oauth-proxy:v4.4 image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants