Bug 1896226: Remove recycler pod templates #2318
Conversation
The template is no longer necessary in MCO because now it's embedded in KCM operator [0]. [0] openshift/cluster-kube-controller-manager-operator#488
openshift-ci-robot
added
bugzilla/severity-high
|
@bertinatto: This pull request references Bugzilla bug 1896226, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
Is this ready @bertinatto ? |
Yes, but we need to wait for openshift/cluster-kube-controller-manager-operator#490 so that we don't break the 4.7 => 4.6 downgrade. |
|
/retest |
|
looks like a pretty rare flake on aws-serial |
|
/test e2e-aws-serial |
That PR is still open so throwing a hold on this to prevent accidental merge. /hold |
|
/retest |
So if we merge this PR before openshift/cluster-kube-controller-manager-operator#490 we will break 4.7 => 4.6 dowgrades. However, if I understand correctly, 4.7 => 4.6 downgrades are already broken since #2248 has been merged. As a result, we won't be supporting 4.7 => 4.6 downgrades and it's OK to go ahead with this PR, is that correct @sjenning? |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/cherry-pick release-4.7 |
|
@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, rphillips, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-agnostic-upgrade |
|
/retest |
1 similar comment
|
/retest |
|
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 1896226 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rphillips: new pull request created: #2434 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.7 |
|
@rphillips: new pull request could not be created: failed to create pull request against openshift/machine-config-operator#release-4.7 from head openshift-cherrypick-robot:cherry-pick-2318-to-release-4.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2318-to-release-4.7."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 participants
- What I did
Removed the recycler pod templates.
- How to verify it
The template files should no longer be created in these locations (master nodes):
- Description for the changelog
The template is no longer necessary in MCO because now it's embedded in
KCM operator: openshift/cluster-kube-controller-manager-operator#488
This PR should be merged after openshift/cluster-kube-controller-manager-operator#488.
/assign @sjenning