Skip to content

[release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 19, 2020
Merged

[release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config #2239

openshift-merge-robot merged 1 commit into from
Nov 19, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 19, 2020

This is an automated cherry-pick of #2229

/assign rphillips

@cgwalters
ctrcfg_test: Wait for our prior target config
f5f7e18 
Waiting for the previous MC isn't right here; we're deleting
a config and so what we want to wait for is the previous pool
target.

Drop the racy `sleep()`.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2020

@openshift-cherrypick-robot: Bugzilla bug 1897361 has been cloned as Bugzilla bug 1899368. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config

Details

In response to this:

[release-4.6] Bug 1897361: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1897361: ctrcfg_test: Wait for our prior target config [release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1899368, which is invalid:

  • expected dependent Bugzilla bug 1897361 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@sinnykumari
Copy link
Contributor

sinnykumari commented Nov 19, 2020

/retest

@rphillips
Copy link
Contributor

rphillips commented Nov 19, 2020

/bugzilla refresh
/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2020

@rphillips: This pull request references Bugzilla bug 1899368, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1897361 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1897361 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

/bugzilla refresh
/lgtm
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 19, 2020

/skip

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 19, 2020 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op f5f7e18 link /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade f5f7e18 link /test okd-e2e-upgrade
ci/prow/okd-e2e-aws f5f7e18 link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 19, 2020

As this is updating a job in our mco test suite: e2e-gcp-op and has nothing to do with any e2e tests overriding to save resources and esxpedite blocked prs

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2020

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws

Details

In response to this:

As this is updating a job in our mco test suite: e2e-gcp-op and has nothing to do with any e2e tests overriding to save resources and esxpedite blocked prs

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips rphillips mentioned this pull request Nov 19, 2020
Closed
@ecordell
Copy link

ecordell commented Nov 19, 2020

approving because this blocks #2213 which is urgent

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0a87cb3 into openshift:release-4.6 Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1899368 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips rphillips mentioned this pull request Nov 19, 2020
Merged
@rphillips
Copy link
Contributor

rphillips commented Dec 3, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2020
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Dec 3, 2020

@rphillips: new pull request created: #2284

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

1 more reviewer

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. team-mco

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @sinnykumari @rphillips @openshift-bot @kikisdeliveryservice @openshift-merge-robot @ecordell @cgwalters