Skip to content

Bug 1897361: ctrcfg_test: Wait for our prior target config #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cgwalters wants to merge 2 commits into from
Closed

Bug 1897361: ctrcfg_test: Wait for our prior target config #2227

cgwalters wants to merge 2 commits into from

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Nov 13, 2020

Waiting for the previous MC isn't right here; we're deleting
a config and so what we want to wait for is the previous pool
target.

Drop the racy sleep().

@cgwalters
ctrcfg_test: Wait for our prior target config
b818d76 
Waiting for the previous MC isn't right here; we're deleting
a config and so what we want to wait for is the previous pool
target.

Drop the racy `sleep()`.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@umohnani8 umohnani8 mentioned this pull request Nov 13, 2020
Closed
@cgwalters cgwalters changed the title ctrcfg_test: Wait for our prior target config Bug 189736: ctrcfg_test: Wait for our prior target config Nov 13, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2020

@cgwalters: This pull request references Bugzilla bug 189736, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.7.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 189736: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 13, 2020
@cgwalters cgwalters changed the title Bug 189736: ctrcfg_test: Wait for our prior target config Bug 1897361: ctrcfg_test: Wait for our prior target config Nov 13, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2020

@cgwalters: This pull request references Bugzilla bug 1897361, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1897361: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 13, 2020
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 13, 2020

Yesterday I was also confused about why they didn't just waitForPoolComplete like we do in MCD tests so this makes sense to me. Obvi would like test run to confirm it but yep. 👍 !

@rphillips
Copy link
Contributor

rphillips commented Nov 13, 2020

ci/prow/e2e-agnostic-upgrade -- gcp IAM error, unrelated

@haircommander
Copy link
Member

haircommander commented Nov 13, 2020 •
edited
Loading

haha it would help to write tests for components I understand... LGTM, good find @cgwalters 😄

@rphillips
Copy link
Contributor

rphillips commented Nov 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor

rphillips commented Nov 13, 2020

/retest

@rphillips
Copy link
Contributor

rphillips commented Nov 13, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 13, 2020

@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 13, 2020

testing another pr without second commit.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 13, 2020

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 52182ff link /test e2e-aws-workers-rhel7
ci/prow/e2e-agnostic-upgrade 52182ff link /test e2e-agnostic-upgrade
ci/prow/e2e-aws 52182ff link /test e2e-aws
ci/prow/e2e-aws-serial 52182ff link /test e2e-aws-serial
ci/prow/okd-e2e-aws 52182ff link /test okd-e2e-aws
ci/prow/e2e-gcp-op 52182ff link /test e2e-gcp-op

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 13, 2020

Closing in favor of #2229 which is the first commit by Colin and the minimal commit necessary to fix the ctrcfg test:

#2229

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2020

@cgwalters: This pull request references Bugzilla bug 1897361. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1897361: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@runcom runcom Awaiting requested review from runcom

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cgwalters @openshift-ci-robot @kikisdeliveryservice @rphillips @haircommander @openshift-cherrypick-robot @openshift-merge-robot