templates: add memory request to etcd-member pod #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
sjenning
force-pushed
the
add-etcd-memory-request
branch
from
6ec9348 to
c5e63a9
Compare
Contributor
Author
|
/retest |
Contributor
|
/approve |
openshift-ci-robot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
…ogressing Bug 1782683: no longer gate removed processing when imagestreams in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One in a series of PRs to set memory requests for all control plane and high memory use components.
We are encountering master instability (openshift/installer#408 openshift/installer#785) as the number of components increase because many components run
BestEffortgiving the scheduler no information on pod resource usage.Looking at prometheus metrics, the etcd-member pod has a min usage of ~200Mi at cluster start, grows to ~600Mi before GCing and dropping to ~400Mi.
Because it is a control plane component, I'm giving it a buffer and setting to max at
600Mi@abhinavdahiya @derekwaynecarr