Skip to content

Conversation

@bdurrow
Copy link

@bdurrow bdurrow commented Oct 14, 2020

A recent change, perhaps the adoption of fcos 33 broke hostname assignment (at least in GCP) because the transient hostname was set to fedora on boot. We need to use the dhcp provided hostname in this case.

- What I did
Modified templates/common/_base/files/etc-networkmanager-dispatcher.d-90-long-hostname.yaml so that the string fedora is treated like localhost when we check to see if the hostname was previously set.

- How to verify it
Build a 4.6 cluster in GCP.

- Description for the changelog

Use dhcp provided hostname when transient hostname is fedora

A recent change, perhaps the adoption of fcos 33 broke hostname assignment (at least in GCP) because the transient hostname was set to fedora on boot.  We need to use the dhcp provided hostname in this case.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bdurrow
To complete the pull request process, please assign lorbuschris after the PR has been reviewed.
You can assign the PR to them by writing /assign @lorbuschris in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

Hi @bdurrow. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2020
@vrutkovs
Copy link
Contributor

Sorry for confusion, but fcos branch is for OKD 4.5. Please re-submit this for master (or release-4.6 branch) to this out on OKD 4.6

@vrutkovs
Copy link
Contributor

Verified that this fix works on OKD 4.6 in GCP. However its odd that default hostname is fedora, it would be easier to keep it localhost on FCOS side

@bdurrow
Copy link
Author

bdurrow commented Oct 14, 2020

Rebased in #2160

@bdurrow bdurrow closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants