Skip to content

Bug 1874696: Add ovs-notification.service #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juanluisvaladas wants to merge 1 commit into from
Closed

Bug 1874696: Add ovs-notification.service #2102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions templates/common/_base/units/ovs-notification.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: ovs-notification.service
enabled: {{if eq .NetworkType "OVNKubernetes"}}true{{else if eq .NetworkType "OpenShiftSDN"}}true{{else}}false{{end}}
contents: |
[Unit]
Description=Creates a file to let the OVS pod know OVS is running on systemd.
Wants=NetworkManager-wait-online.service
After=NetworkManager-wait-online.service openvswitch.service
Before=network-online.target kubelet.service

[Service]
# Need oneshot to delay kubelet
Type=oneshot
# Create the file in a tmpfs so that the file gets deleted on restart
ExecStart=/usr/bin/touch /var/run/openvswitch/ovs-notification
StandardOutput=journal+console
StandardError=journal+console

[Install]
WantedBy=network-online.target
Copy link
Contributor

@danwinship danwinship Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Author

@juanluisvaladas juanluisvaladas Sep 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the network so I'd say we can't consider the network completely setup until this unit is complete. I would also make sense in the network.target but I think network-online.target is the most logical place.

Anyway I don't feel strongly enough about this to block the PR while we discuss where it should go, so if you want it somewhere else I'll move it.

Copy link
Contributor

@trozet trozet Sep 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right to say wanted by network online target, but then in runtime this is running before network online target