Bug 1876216: Check if /etc/resolv.conf is present before overriding #2062

Gal-Zaidman · 2020-09-06T12:47:39Z

We copy /var/run/NetworkManager/resolv.conf to /etc/resolv.conf for the case that /etc/resolv.conf is not present, but if it is present we override it.
On oVirt this causes the api-int to not be resolvable for a short period of time, causing failures and events.
This PR adds a check to override cp only if it is not present.

Notice that at the end of this script we replace it with a new file anyway but that is ok.

** Sent this fix to all the platforms that have similar logic to be consistent

Signed-off-by: Gal-Zaidman [email protected]

- What I did

Added a check to see if /etc/resolv.conf exist before overriding it

- Description for the changelog

Check if /etc/resolv.conf is present before overriding at the beginning of NetworkManager-resolv-prepender

openshift-ci-robot · 2020-09-06T12:47:42Z

@Gal-Zaidman: This pull request references Bugzilla bug 1876216, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1876216: Check if /etc/resolv.conf is present before overriding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman · 2020-09-06T12:58:49Z

/cc @mandre

Gal-Zaidman · 2020-09-06T12:59:22Z

/bugzilla refresh

openshift-ci-robot · 2020-09-06T12:59:29Z

@Gal-Zaidman: This pull request references Bugzilla bug 1876216, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman · 2020-09-06T13:00:11Z

/test e2e-ovirt
/test e2e-openstack
/test e2e-vshpere

openshift-ci-robot · 2020-09-06T13:03:08Z

@Gal-Zaidman: This pull request references Bugzilla bug 1876216, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1876216: Check if /etc/resolv.conf is present before overriding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman · 2020-09-06T13:25:54Z

/test e2e-ovirt

Gal-Zaidman · 2020-09-07T07:27:23Z

/test e2e-ovirt

Gal-Zaidman · 2020-09-07T08:57:13Z

/test e2e-ovirt

We copy /var/run/NetworkManager/resolv.conf to /etc/resolv.conf for the case that /etc/resolv.conf is not present, but if it is present we override it. On oVirt is causes the api-int to not be resolveable for a short period of time, causing failures and events. This PR adds a check to override cp only if it is not present. Notice that at the end of this script we replace it with a new file anyway but that is ok. Signed-off-by: Gal-Zaidman <[email protected]>

Gal-Zaidman · 2020-09-07T10:44:10Z

/assign @sinnykumari

mandre · 2020-09-07T11:18:01Z

/test e2e-ovirt
/test e2e-openstack
/test e2e-vshpere

mandre · 2020-09-07T14:42:28Z

All good for OpenStack 👍

openshift-bot · 2020-09-09T02:58:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T03:10:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T03:23:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T03:36:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T03:48:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T04:15:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T04:28:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T04:54:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T05:20:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T05:32:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T05:45:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T06:12:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T06:25:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T06:37:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T06:50:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T07:17:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T07:43:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T08:23:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T09:01:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T09:13:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T09:52:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-09T10:04:08Z

@Gal-Zaidman: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	`03c8800`	link	`/test e2e-vsphere`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-09-09T10:05:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-09T10:17:38Z

@Gal-Zaidman: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2062

Bugzilla bug 1876216 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1876216: Check if /etc/resolv.conf is present before overriding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2020-09-15T12:32:36Z

It looks like this breaks some baremetal IPI deployments, since it's possible for resolv.conf to exist like:

[core@localhost ~]$ cat /etc/resolv.conf
# Generated by NetworkManager
search local <somedomain>

This won't work for external resolution though, so the podman then fails to pull the image and we reintroduce the bug fixed via #1765

So I think we either need to partially revert this (for the baremetal platform), or do some smarter check to still overwrite the resolv.conf when it only contains a local search domain and no upstream DNS?

/cc @celebdor @bcrochet @stbenjam

yuqi-zhang · 2020-09-16T19:42:45Z

This appears to break rhel workers: https://bugzilla.redhat.com/show_bug.cgi?id=1879322

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 6, 2020

openshift-ci-robot requested review from iamemilio and pierreprinetti September 6, 2020 12:47

openshift-ci-robot requested a review from mandre September 6, 2020 12:58

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 6, 2020

Gal-Zaidman changed the title ~~Bug 1876216: Check if /etc/resolv.conf is present before overriding~~ WIP: Bug 1876216: Check if /etc/resolv.conf is present before overriding Sep 6, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2020

Gal-Zaidman force-pushed the dns-prepender-race branch from 3a11190 to f90ee08 Compare September 7, 2020 07:24

Gal-Zaidman force-pushed the dns-prepender-race branch from f90ee08 to 2f10ace Compare September 7, 2020 08:23

Gal-Zaidman force-pushed the dns-prepender-race branch from 2f10ace to 03c8800 Compare September 7, 2020 10:20

Gal-Zaidman changed the title ~~WIP: Bug 1876216: Check if /etc/resolv.conf is present before overriding~~ Bug 1876216: Check if /etc/resolv.conf is present before overriding Sep 7, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2020

openshift-ci-robot assigned sinnykumari Sep 7, 2020

openshift-merge-robot merged commit 40c3cc0 into openshift:master Sep 9, 2020

openshift-ci-robot requested review from bcrochet, celebdor and stbenjam September 15, 2020 12:32

Bug 1876216: Check if /etc/resolv.conf is present before overriding #2062

Bug 1876216: Check if /etc/resolv.conf is present before overriding #2062

Uh oh!

Conversation

Gal-Zaidman commented Sep 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 6, 2020

Uh oh!

Gal-Zaidman commented Sep 6, 2020

Uh oh!

Gal-Zaidman commented Sep 6, 2020

Uh oh!

openshift-ci-robot commented Sep 6, 2020

Uh oh!

Gal-Zaidman commented Sep 6, 2020

Uh oh!

openshift-ci-robot commented Sep 6, 2020

Uh oh!

Gal-Zaidman commented Sep 6, 2020

Uh oh!

Gal-Zaidman commented Sep 7, 2020

Uh oh!

Gal-Zaidman commented Sep 7, 2020

Uh oh!

Gal-Zaidman commented Sep 7, 2020

Uh oh!

mandre commented Sep 7, 2020

Uh oh!

mandre commented Sep 7, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-ci-robot commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 9, 2020

Uh oh!

openshift-ci-robot commented Sep 9, 2020

Uh oh!

Gal-Zaidman commented Sep 6, 2020 •

edited

Loading

openshift-ci-robot commented Sep 9, 2020 •

edited

Loading

hardys commented Sep 15, 2020 •

edited

Loading