Skip to content

Conversation

@mandre
Copy link
Member

@mandre mandre commented Sep 1, 2020

Patch at #1817
addressed the drift of kubelet configuration for control plane nodes but
didn't update compute nodes' kubelet to catch up changes made to the
main kubelet unit.

We're currently missing a number of fixes for the worker nodes on
Baremetal, OpenStack and vSphere platforms:

This change sync the custom kubelet unit files accross platforms.

Patch at openshift#1817
addressed the drift of kubelet configuration for control plane nodes but
didn't update compute nodes' kubelet to catch up changes made to the
main kubelet unit.

We're currently missing a number of fixes for the worker nodes on
Baremetal, OpenStack and vSphere platforms:
- https://bugzilla.redhat.com/show_bug.cgi?id=1823967
- https://bugzilla.redhat.com/show_bug.cgi?id=1806027
- https://bugzilla.redhat.com/show_bug.cgi?id=1828622

This change sync the custom kubelet unit files accross platforms.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1874448, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1874448: [BM, OpenStack, vSphere]: Sync compute kubelet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Sep 1, 2020

/cc @russellb @jcpowermac
Please take a look, this touches the BM and vSphere files.

@cgwalters
Copy link
Member

Argh. OK after this we really need to invent /etc/kubelet.conf.d or (shorter term) start generating the config from code in the MCC rather than templating.

@cgwalters
Copy link
Member

/approve
Changes LGTM - leaving to an MCO team member to lgtm.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@russellb
Copy link
Contributor

russellb commented Sep 1, 2020

lgtm -- ideally would like to see e2e-metal-ipi pass for the bare metal change first

@russellb
Copy link
Contributor

russellb commented Sep 2, 2020

e2e-metal-ipi passed, so I'm good with this.

@mandre did you want to see openstack CI run? We should probably kick off vsphere too ...

@russellb
Copy link
Contributor

russellb commented Sep 2, 2020

/test e2e-openstack

@russellb
Copy link
Contributor

russellb commented Sep 2, 2020

/test e2e-vsphere

Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Fedosin
Copy link
Contributor

Fedosin commented Sep 3, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, Fedosin, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor

Fedosin commented Sep 3, 2020

/retest

1 similar comment
@mandre
Copy link
Member Author

mandre commented Sep 3, 2020

/retest

@mandre
Copy link
Member Author

mandre commented Sep 4, 2020

/test e2e-vsphere
@jcpowermac we're only missing the green light for vsphere 🚦

@mandre
Copy link
Member Author

mandre commented Sep 8, 2020

/hold cancel
vsphere job hasn't passed since 2020-06-15, and the failure seems unrelated with the proposed change.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fdf00c3 into openshift:master Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: All pull requests linked via external trackers have merged:

Bugzilla bug 1874448 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1874448: [BM, OpenStack, vSphere]: Sync compute kubelet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants