-
Notifications
You must be signed in to change notification settings - Fork 462
Bug 1874448: [BM, OpenStack, vSphere]: Sync compute kubelet #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1874448: [BM, OpenStack, vSphere]: Sync compute kubelet #2045
Conversation
Patch at openshift#1817 addressed the drift of kubelet configuration for control plane nodes but didn't update compute nodes' kubelet to catch up changes made to the main kubelet unit. We're currently missing a number of fixes for the worker nodes on Baremetal, OpenStack and vSphere platforms: - https://bugzilla.redhat.com/show_bug.cgi?id=1823967 - https://bugzilla.redhat.com/show_bug.cgi?id=1806027 - https://bugzilla.redhat.com/show_bug.cgi?id=1828622 This change sync the custom kubelet unit files accross platforms.
|
@mandre: This pull request references Bugzilla bug 1874448, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @russellb @jcpowermac |
|
Argh. OK after this we really need to invent |
|
/approve |
|
lgtm -- ideally would like to see e2e-metal-ipi pass for the bare metal change first |
|
e2e-metal-ipi passed, so I'm good with this. @mandre did you want to see openstack CI run? We should probably kick off vsphere too ... |
|
/test e2e-openstack |
|
/test e2e-vsphere |
Fedosin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, Fedosin, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-vsphere |
|
/hold cancel |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mandre: All pull requests linked via external trackers have merged: Bugzilla bug 1874448 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Patch at #1817
addressed the drift of kubelet configuration for control plane nodes but
didn't update compute nodes' kubelet to catch up changes made to the
main kubelet unit.
We're currently missing a number of fixes for the worker nodes on
Baremetal, OpenStack and vSphere platforms:
This change sync the custom kubelet unit files accross platforms.