*: init apis and client #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
ashcrow
reviewed
Jul 26, 2018
Member
ashcrow
left a comment
ashcrow
left a comment
There was a problem hiding this comment.
There is too much to really review in depth, but I perused some of the non generated go code, configs, and shell scripts and they look good.
abhinavdahiya
force-pushed
the
add_apis_client
branch
from
60fc8ac to
753556d
Compare
crawford
approved these changes
Jul 26, 2018
abhinavdahiya
force-pushed
the
add_apis_client
branch
from
753556d to
1617f80
Compare
wking
added a commit
to wking/machine-config-operator
that referenced
this pull request
Feb 28, 2019
There seems to have been some initial uncertainty about what this would be called, with MachinePool first landing in 30d522f (docs: add initial documentation of design, 2018-07-25) and MachineConfigPool first landing in cfc9660 (pkg/apis: add machineconfiguration.openshift.io apis, 2018-07-26, openshift#2). This commit consolidates us around MachineConfigPool, except for the machine-pools/ bootstrap path (since changing that would require consumer updates).
alaypatel07
pushed a commit
to alaypatel07/machine-config-operator
that referenced
this pull request
Sep 30, 2019
*: use kubecsr mount, add readiness probe to etcd pod
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
operator-sdk new output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.