Skip to content

Bug 1861095: daemon: Log when we validate that FIPS is on #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 11, 2020
Merged

Bug 1861095: daemon: Log when we validate that FIPS is on #1990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/daemon/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,11 +629,14 @@ func checkFIPS(current, desired *mcfgv1.MachineConfig) error {
return errors.Wrapf(err, "Error parsing FIPS file at %s", fipsFile)
}
if desired.Spec.FIPS == nodeFIPS {
if desired.Spec.FIPS {
glog.Infof("FIPS is configured and enabled")
}
// Check if FIPS on the system is at the desired setting
current.Spec.FIPS = nodeFIPS
return nil
}
return errors.New("detected change to FIPS flag. Refusing to modify FIPS on a running cluster")
return errors.New("detected change to FIPS flag; refusing to modify FIPS on a running cluster")
}

// checks for white-space characters in "C" and "POSIX" locales.
Expand Down