Bug 1861876: telemetry: change MCDDrainErr from critical to warning #1959
Conversation
Failed drain should be warning until metrics reworked.
openshift-ci-robot
added
the
approved
|
/approve |
|
Fixup for #1223, which was new in 4.3. Does this need an attached bug for backporting, or did we want to wait and backport once the additional rerolling is completed? |
|
/lgtm I think we can wait for the refactor to backport if needed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kikisdeliveryservice
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1861876, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
Added this as a BZ to backport to give a better & less confusing UX until telemetry refactor. /cherry-pick release-4.5 |
|
@kikisdeliveryservice: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kikisdeliveryservice: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1959. Bugzilla bug 1861876 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kikisdeliveryservice: new pull request created: #1966 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
This was initially made critical, but that seems to be overkill so move to warning (probably should have been from the start). Prom rules are going to be refactored, so will bake in more nuance at that time.