Skip to content

hack: change override env for version in build-go.sh #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 23, 2018
Merged

hack: change override env for version in build-go.sh #191

openshift-merge-robot merged 1 commit into from
Nov 23, 2018

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Nov 21, 2018 •
edited
Loading

One of the CI runs shows 1.10.3 as the version chosen for build of machine config operator

Pulling image "docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline@sha256:daa33010e3225f7abefc2358aaff9891353e86b3d7dde7257982fb487a298e6b" ...
Replaced Dockerfile FROM image registry.svc.ci.openshift.org/openshift/origin-v4.0:base

Pulling image docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline@sha256:02b13d581ad7d92b43d0557a26e804c06f7f35261cbed17ac91b21a468483ff9 ...

Pulling image registry.svc.ci.openshift.org/openshift/release:golang-1.10 ...
--> FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 as builder
--> WORKDIR /go/src/github.com/openshift/machine-config-operator
--> COPY . .
--> RUN WHAT=machine-config-operator ./hack/build-go.sh
Building github.com/openshift/machine-config-operator/cmd/machine-config-operator (1.10.3)
--> FROM docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline@sha256:02b13d581ad7d92b43d0557a26e804c06f7f35261cbed17ac91b21a468483ff9 as 1
--> COPY --from=builder /go/src/github.com/openshift/machine-config-operator/_output/linux/amd64/machine-config-operator /usr/bin/
--> COPY install /manifests
--> ENTRYPOINT ["/usr/bin/machine-config-operator"]
--> LABEL io.openshift.release.operator=true
--> ENV "OPENSHIFT_BUILD_NAME"="machine-config-operator" "OPENSHIFT_BUILD_NAMESPACE"="ci-op-39bh1qy5"
--> LABEL "io.openshift.build.name"="machine-config-operator" "io.openshift.build.namespace"="ci-op-39bh1qy5" "vcs-ref"="" "vcs-url"="" "io.openshift.build.commit.id"="" "io.openshift.build.commit.message"="" "io.openshift.build.commit.author"="" "io.openshift.build.source-location"="" "io.openshift.build.source-context-dir"="" "vcs-type"="" "io.openshift.build.name"="" "io.openshift.build.namespace"="" "io.openshift.build.commit.ref"="" "io.openshift.build.commit.date"=""
--> Committing changes to temp.builder.openshift.io/ci-op-39bh1qy5/machine-config-operator:b2d8da48 ...
--> Done

Pushing image docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline:machine-config-operator ...
Pushed 2/3 layers, 71% complete
Pushed 3/3 layers, 100% complete
Push successful

Building github.com/openshift/machine-config-operator/cmd/machine-config-operator (1.10.3)

Turns out registry.svc.ci.openshift.org/openshift/release:golang-1.10 has VERSION env set to golang's version. So switching to VERSION_OVERRIDE prevents conflicts.

/cc @jlebon @ashcrow

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2018
@abhinavdahiya abhinavdahiya changed the title hack: change overide env for version in build-go.sh hack: change override env for version in build-go.sh Nov 21, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2018
@abhinavdahiya
hack: change override env for version in build-go.sh
a167af1 
One of the CI runs shows `1.10.3` as the version chosen for build of machine config operator
```console
Pulling image "docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline@sha256:daa33010e3225f7abefc2358aaff9891353e86b3d7dde7257982fb487a298e6b" ...
Replaced Dockerfile FROM image registry.svc.ci.openshift.org/openshift/origin-v4.0:base

Pulling image docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline@sha256:02b13d581ad7d92b43d0557a26e804c06f7f35261cbed17ac91b21a468483ff9 ...

Pulling image registry.svc.ci.openshift.org/openshift/release:golang-1.10 ...
--> FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 as builder
--> WORKDIR /go/src/github.com/openshift/machine-config-operator
--> COPY . .
--> RUN WHAT=machine-config-operator ./hack/build-go.sh
Building github.com/openshift/machine-config-operator/cmd/machine-config-operator (1.10.3)
--> FROM docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline@sha256:02b13d581ad7d92b43d0557a26e804c06f7f35261cbed17ac91b21a468483ff9 as 1
--> COPY --from=builder /go/src/github.com/openshift/machine-config-operator/_output/linux/amd64/machine-config-operator /usr/bin/
--> COPY install /manifests
--> ENTRYPOINT ["/usr/bin/machine-config-operator"]
--> LABEL io.openshift.release.operator=true
--> ENV "OPENSHIFT_BUILD_NAME"="machine-config-operator" "OPENSHIFT_BUILD_NAMESPACE"="ci-op-39bh1qy5"
--> LABEL "io.openshift.build.name"="machine-config-operator" "io.openshift.build.namespace"="ci-op-39bh1qy5" "vcs-ref"="" "vcs-url"="" "io.openshift.build.commit.id"="" "io.openshift.build.commit.message"="" "io.openshift.build.commit.author"="" "io.openshift.build.source-location"="" "io.openshift.build.source-context-dir"="" "vcs-type"="" "io.openshift.build.name"="" "io.openshift.build.namespace"="" "io.openshift.build.commit.ref"="" "io.openshift.build.commit.date"=""
--> Committing changes to temp.builder.openshift.io/ci-op-39bh1qy5/machine-config-operator:b2d8da48 ...
--> Done

Pushing image docker-registry.default.svc:5000/ci-op-39bh1qy5/pipeline:machine-config-operator ...
Pushed 2/3 layers, 71% complete
Pushed 3/3 layers, 100% complete
Push successful
```
Turns out `registry.svc.ci.openshift.org/openshift/release:golang-1.10` has `VERSION` env set to golang's version. So switching to `VERSION_OVERRIDE` prevents conflicts.
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Nov 22, 2018 

level=debug msg="Running &exec.Cmd{Path:\"/usr/bin/terraform\", Args:[]string{\"/usr/bin/terraform\", \"init\", \"-input=false\", \"-no-color\"}, Env:[]string(nil), Dir:\"/tmp/openshift-install-979752821\", Stdin:io.Reader(nil), Stdout:io.Writer(nil), Stderr:io.Writer(nil), ExtraFiles:[]*os.File(nil), SysProcAttr:(*syscall.SysProcAttr)(nil), Process:(*os.Process)(nil), ProcessState:(*os.ProcessState)(nil), ctx:context.Context(nil), lookPathErr:error(nil), finished:false, childFiles:[]*os.File(nil), closeAfterStart:[]io.Closer(nil), closeAfterWait:[]io.Closer(nil), goroutine:[]func() error(nil), errch:(chan error)(nil), waitDone:(chan struct {})(nil)}..."
level=debug msg="Running &exec.Cmd{Path:\"/usr/bin/terraform\", Args:[]string{\"/usr/bin/terraform\", \"apply\", \"-auto-approve\", \"-input=false\", \"-no-color\", \"-state=terraform.tfstate\"}, Env:[]string(nil), Dir:\"/tmp/openshift-install-979752821\", Stdin:io.Reader(nil), Stdout:io.Writer(nil), Stderr:io.Writer(nil), ExtraFiles:[]*os.File(nil), SysProcAttr:(*syscall.SysProcAttr)(nil), Process:(*os.Process)(nil), ProcessState:(*os.ProcessState)(nil), ctx:context.Context(nil), lookPathErr:error(nil), finished:false, childFiles:[]*os.File(nil), closeAfterStart:[]io.Closer(nil), closeAfterWait:[]io.Closer(nil), goroutine:[]func() error(nil), errch:(chan error)(nil), waitDone:(chan struct {})(nil)}..."
level=error msg="Error: Error applying plan:\n\n1 error(s) occurred:\n\n* aws_route53_zone.tectonic_int: 1 error(s) occurred:\n\n* aws_route53_zone.tectonic_int: timeout while waiting for state to become 'INSYNC' (last state: 'PENDING', timeout: 15m0s)\n\nTerraform does not automatically rollback in the face of errors.\nInstead, your Terraform state file has been partially updated with\nany resources that successfully completed. Please address the error\nabove and apply again to incrementally change your infrastructure."
level=fatal msg="Error executing openshift-install: failed to fetch Cluster: failed to generate asset \"Cluster\": failed to run terraform: failed to execute Terraform: exit status 1"
2018/11/21 23:52:11 Container setup in pod e2e-aws failed, exit code 1, reason Error
Another process exited

/retest

@abhinavdahiya abhinavdahiya mentioned this pull request Nov 22, 2018
Merged
@jlebon
Copy link
Member

jlebon commented Nov 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9f7eeac into openshift:master Nov 23, 2018
abhinavdahiya added a commit to abhinavdahiya/cluster-version-operator that referenced this pull request Feb 8, 2019
@abhinavdahiya
hack: change override env for version
e4599d1 
Similar to openshift/machine-config-operator#191.
Turns out `registry.svc.ci.openshift.org/openshift/release:golang-1.10` has `VERSION` env set to golang's version.
So switching to `VERSION_OVERRIDE` prevents conflicts.
@abhinavdahiya abhinavdahiya mentioned this pull request Feb 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@jlebon jlebon Awaiting requested review from jlebon

Assignees

@jlebon jlebon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinavdahiya @jlebon @openshift-ci-robot @openshift-bot @openshift-merge-robot