Skip to content

machine-config-daemon-host.service: Stop enabling by default #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cgwalters wants to merge 1 commit into from
Closed

machine-config-daemon-host.service: Stop enabling by default #1804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions templates/common/_base/units/machine-config-daemon-host.service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ contents: |
# TODO add --from-etc-pullspec after ratcheting
ExecStart=/usr/libexec/machine-config-daemon pivot

[Install]
WantedBy=multi-user.target
Copy link
Contributor

@sinnykumari sinnykumari Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to remove this as it may not adding up in this service.

Speaking out loud:
From the documentation https://www.freedesktop.org/software/systemd/man/systemd.unit.html , it says WantedBy= option may be used more than once, or a space-separated list of unit names may be given. A symbolic link is created in the .wants/ or .requires/ directory of each of the listed units when this unit is installed by systemctl enable. By default m-c-d-host.service is in disabled state, so I hope this wasn't causing any issue so far.

Copy link
Member Author

@cgwalters cgwalters Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhhh I had completely missed that we had enabled: false. Thanks! That's indeed why the services aren't clashing.

dropins:
- name: 10-mco-default-env.conf
contents: |
Expand Down