[release-4.4] Bug 1845635: Fix quorum-guard timeouts #1798
Conversation
Before this change, the quorum-guard `timeoutSeconds` and `failureThreshold` values were left unspecified in the manifest, and were defaulted. The default value for `timeoutSeconds` is 1, while the probe itself enforces a 2 second timeout. This means that in cases where the probe itself should succeed, Kube will consider the probe failed because of the stricter timeout on the probe specification. The effect is the probe sporadically reports false negative outcomes. This change increases the `timeoutSeconds` value to exceed the probe logic's internal timeout so that the probe command is the source of truth with regards to timeouts. This change also makes the `failureThreshold` value explicit, but the default value is preserved because I don't have a clear reason yet to change it.
|
@openshift-cherrypick-robot: Bugzilla bug 1829923 has been cloned as Bugzilla bug 1845635. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1845635, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
This has a an indentation bug causing the change to silently fail, will open a new PR. /close |
|
@ironcladlou: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This is an automated cherry-pick of #1797
/assign ironcladlou