[OKD] Proxy for machine config daemon firstboot

[evertmulder]

This PR fixes okd-project/okd#19. On fcos the machine-config-daemon-firstboot cannot pull images when behind a proxy.
This PR configures the proxy settings for the machine-config-daemon-firstboot service.

- How to verify it
Start an OKD installation using proxy settings in the install-config.yaml. The master would fail with

Error: unable to pull quay.io/openshift/okd-content@sha256:6625bb97a35604080af348340f0788df36455352b1a039f073cb6894c548fb78: unable to pull image: Error initializing source docker://quay.io/openshift/okd-content@sha256:6625bb97a35604080af348340f0788df36455352b1a039f073cb6894c548fb78: pinging docker registry returned: Get https://quay.io/v2/: dial tcp 3.230.48.144:443: i/o timeout

After the PR the image should be pulled using the configured proxy.

- Description for the changelog

[openshift-ci-robot]

Hi @evertmulder. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[LorbusChris]

@evertmulder thank you for your contribution, this is highly appreciated!

Is there a reason not to merge the dropin file with the service unit definition at https://github.com/openshift/machine-config-operator/blob/fcos/templates/common/_base/units/machine-config-daemon-firstboot.service?

If you could also open a PR against master: https://github.com/openshift/machine-config-operator/blob/master/templates/common/_base/units/machine-config-daemon-firstboot.service that'd be ideal :) actually, this is not yet needed on the master branch since MCD isn't pulled from the MCO container image there yet.

[evertmulder]

@LorbusChris

Is there a reason not to merge the dropin file with the service unit definition at https://github.com/openshift/machine-config-operator/blob/fcos/templates/common/_base/units/machine-config-daemon-firstboot.service?

I guest not. This looks in line with the other proxy injections like _base/files/etc-systemd-system-machine-config-daemon-host.service.d-10-default-env.conf.yaml, _base/files/etc-systemd-system-kubelet.service.d-10-default-env.conf.yaml and _base/files/etc-systemd-system-crio.service.d-10-default-env.conf.yaml.

[vrutkovs]

/ok-to-test

Lets keep in line with other service dropins here. I updated 4.5 fcos branch and moved dropins to the service definition so that Ignition translator would be happy

[LorbusChris]

Note that this here is going to land in master soon: 4b1f622.

Instead of a plain Ignition file, this should really be an ignition systemd unit content (or dropin).

[LorbusChris]

Some of the systemd dropins are indeed laid out as ignition files, even though they should really be ignition systemd dropins.

[evertmulder]

Tested the PR on our environment and the the installation behind a proxy is working now.

[LorbusChris]

This PR looks fine. I think we can merge as is. In master, this will be superseded by #1766
/approve

[vrutkovs]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evertmulder, LorbusChris, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LorbusChris,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[LorbusChris]

@evertmulder thank you so much for taking the initiative and putting up the PR! 🎉