machine-config-daemon-host: Also Before=crio.service #1761
Conversation
openshift-ci-robot
added
the
approved
|
This won't merge right away this week but lgtm'ing it /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hmm I'm seeing |
yeah I agree, I would say it makes most sense to have crio-wipe happen right before crio, if possible |
This came up in discussions around here: openshift#1706 (comment) There's no reason to start crio either, and it's confusing to do so because in that bug it made us think there was a crio problem when there wasn't. Add `crio-wipe.service` here too because it's part of `crio.service`.
cgwalters
force-pushed
the
host-before-crio
branch
from
31c7790 to
a6ab1f9
Compare
|
New changes are detected. LGTM label has been removed. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I rolled this into #1762 |
4 participants
This came up in discussions around here:
#1706 (comment)
There's no reason to start crio either, and it's confusing
to do so because in that bug it made us think there was a
crio problem when there wasn't.