Skip to content

cmd: Configure klog to match glog #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wking wants to merge 1 commit into from
Closed

cmd: Configure klog to match glog #1730

wking wants to merge 1 commit into from

Conversation

@wking
Copy link
Member

@wking wking commented May 13, 2020 •
edited
Loading

To try and understand why compute nodes sometimes have a long delay between informer initialization and the initial MachineConfig retrieval in getStateAndConfigs.

https://bugzilla.redhat.com/show_bug.cgi?id=1834895

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2020
@wking wking force-pushed the assorted-informer-logging branch 4 times, most recently from d5a2bd4 to dd9cfe0 Compare May 14, 2020 02:58
@wking wking mentioned this pull request May 14, 2020
Merged
@wking wking force-pushed the assorted-informer-logging branch from 2ffa0f6 to 86de0f2 Compare May 14, 2020 16:52
@wking wking changed the title WIP: Assorted informer debugging cmd: Configure klog to match glog May 14, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2020
@wking
Copy link
Member Author

wking commented May 14, 2020

Repurposed this branch to just be about klog/glog compat. This gives us the ability to use -v=10 when calling our executables and get all of the klog goodness out of our vendored Kubernetes libraries.

I also drop some flag parsing which had been used by version commands which print the version and exist, and so never actually needed the logging stack to be configured.

@kikisdeliveryservice kikisdeliveryservice self-requested a review May 14, 2020 17:01
@wking
cmd: Configure klog to match glog
5d4d256 
Following [1,2].  This gives us the ability to use -v=10 when calling
our executables and get all of the klog goodness out of our vendored
Kubernetes libraries.

I also drop some flag parsing which had been used by 'version'
commands which print the version and exist, and so never actually
needed the logging stack to be configured.

[1]: https://github.com/kubernetes/klog#coexisting-with-glog
[2]: https://github.com/kubernetes/klog/blob/a5796cb0e98abe2d0500974a80ec960af26cfd93/examples/coexist_glog/coexist_glog.go
@wking wking force-pushed the assorted-informer-logging branch from 86de0f2 to 5d4d256 Compare May 14, 2020 18:55
@wking
Copy link
Member Author

wking commented May 14, 2020

rhel7 job failed, but shows that MCD logs still have the Version: ... string and such, and don't appear to be any more chatty than they used to be. Presumably bumping -v=.. on them (like dd9cfe02 or some subset of that previous commit) would give us all the klog volume we want for debugging tricky vendored-code behavior.

@ashcrow ashcrow mentioned this pull request May 18, 2020
Merged
@cgwalters cgwalters added the 4.7 Work deferred for 4.7 label Sep 3, 2020
cgwalters
cgwalters approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not intimately familiar with glog vs klog, this overall looks like a nice cleanup though!

Adding 4.7 label.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@kikisdeliveryservice kikisdeliveryservice added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 5d4d256 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-proxy 5d4d256 link /test e2e-aws-proxy
ci/prow/e2e-upgrade 5d4d256 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 5, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-upgrade 5d4d256 link /test e2e-agnostic-upgrade
ci/prow/e2e-aws-serial 5d4d256 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 4, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 6, 2021

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 6, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2021

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

No one assigned

Labels

4.7 Work deferred for 4.7 approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wking @openshift-ci-robot @openshift-merge-robot @openshift-bot @cgwalters @kikisdeliveryservice