Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly #1679

haircommander · 2020-04-23T20:59:09Z

- What I did
with a new version of cri-o, we are going to cleanup containers when a node reboots (which we detect when a tmpfs file is removed), and cleanup images when a node upgraded (which we detect how we used to: persistent version file out of date)
This PR changes where cri-o looks for those files. These match the upstream defaults, so when we move to drop in files, we won't need to specify these

- How to verify it
containers are cleared on node reboot, images are cleared when we bump a cri-o minor version (1.17->1.18)
- Description for the changelog

with a new version of cri-o, we are going to cleanup containers when a node reboots (which we detect when a tmpfs file is removed), and cleanup images when a node upgraded (which we detect how we used to: persistent version file out of date) This PR changes where cri-o looks for those files. These match the upstream defaults, so when we move to drop in files, we won't need to specify these Signed-off-by: Peter Hunt <[email protected]>

openshift-ci-robot · 2020-04-23T20:59:12Z

@haircommander: This pull request references Bugzilla bug 1826896, which is invalid:

expected dependent Bugzilla bug 1826895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-04-23T20:59:42Z

/hold

needs cri-o/cri-o#3635 integrated into 4.4 first

kikisdeliveryservice · 2020-04-23T21:29:12Z

@mrunalp PTAL

mrunalp · 2020-04-23T21:54:40Z

LGTM

kikisdeliveryservice

approving sthis but will need lgtm and passing ci via a new rpm (which is all in progress)

ashcrow · 2020-04-25T04:04:46Z

Updated cri-o will be pinned in the boot image via openshift/installer#3508

mrunalp · 2020-04-25T04:12:47Z

/lgtm

openshift-ci-robot · 2020-04-25T04:13:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kikisdeliveryservice, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kikisdeliveryservice · 2020-04-25T04:40:16Z

Hold to be lifted by @ashcrow & @mrunalp in the morning after we rekick ci and verify with promoted image.

ashcrow · 2020-04-25T11:03:59Z

/retest

ashcrow · 2020-04-25T13:04:43Z

/retest

ashcrow · 2020-04-25T13:47:50Z

/retest

ashcrow · 2020-04-25T14:32:03Z

/retest

cgwalters · 2020-04-25T16:33:25Z

containers are cleared on node reboot, images are cleared when we bump a cri-o minor version (1.17->1.18)

Clearing containers on reboot makes total sense for cri-o. But...clearing images conflicts with the messaging in openshift/machine-api-operator#565 to some degree. The story still holds for minor updates of course. Ideally at some point we have rigorous enough testing for the containers/image layer across upgrades that we don't need to do this (or, we only do it for actually breaking changes to the image store).

mrunalp · 2020-04-25T16:44:20Z

Ideally at some point we have rigorous enough testing for the containers/image layer across upgrades that we don't need to do this (or, we only do it for actually breaking changes to the image store).

Yes, agree with this 👍 With rigorous enough testing we can rely on the kubelet to gc older images.

kikisdeliveryservice · 2020-04-25T17:27:19Z

used old images

/retest

openshift-ci-robot · 2020-04-25T17:30:26Z

@haircommander: This pull request references Bugzilla bug 1826896, which is invalid:

expected dependent Bugzilla bug 1826895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-25T22:20:48Z

@haircommander: This pull request references Bugzilla bug 1826896, which is invalid:

expected dependent Bugzilla bug 1826895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2020-04-25T23:37:44Z

/test e2e-gcp-upgrade

kikisdeliveryservice · 2020-04-25T23:53:49Z

level=fatal msg="failed to fetch Cluster: failed to fetch dependency of \"Cluster\": failed to generate asset \"Platform Permissions Check\": validate AWS credentials: checking install permissions: error simulating policy: Throttling: Rate exceeded\n\tstatus code: 400, request id: 240145ea-661f-46ef-8699-cdb968f7d7f4"

/test e2e-aws-scaleup-rhel7

kikisdeliveryservice · 2020-04-26T00:01:59Z

waiting on e2e-gcp-op & e2e-gcp-upgrade to finish..

rhel7 job (not reqd) seems to be going through something today. ¯_(ツ)_/¯

kikisdeliveryservice · 2020-04-26T00:15:37Z

/skip

openshift-ci-robot · 2020-04-26T00:59:33Z

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`c280fa6`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2020-04-26T01:00:41Z

/retest

openshift-ci-robot · 2020-04-26T03:14:54Z

@haircommander: All pull requests linked via external trackers have merged: cri-o/cri-o#3635, openshift/installer#3508, openshift/machine-config-operator#1679. Bugzilla bug 1826896 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/urgent label Apr 23, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 23, 2020

openshift-ci-robot requested review from mtrmac and umohnani8 April 23, 2020 20:59

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2020

kikisdeliveryservice self-requested a review April 23, 2020 21:28

kikisdeliveryservice assigned umohnani8 and mrunalp Apr 23, 2020

kikisdeliveryservice approved these changes Apr 24, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2020

openshift-ci-robot mentioned this pull request Apr 25, 2020

Bug 1826896: rhcos: bump RHCOS boot image to 44.81.202004250133-0 openshift/installer#3508

Merged

mrunalp removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2020

mrunalp added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2020

kikisdeliveryservice closed this Apr 25, 2020

kikisdeliveryservice reopened this Apr 25, 2020

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 25, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 25, 2020

mrunalp removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 25, 2020

wking added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 25, 2020

kikisdeliveryservice closed this Apr 25, 2020

kikisdeliveryservice reopened this Apr 25, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 25, 2020

mrunalp added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 25, 2020

mrunalp removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2020

openshift-merge-robot merged commit c83f295 into openshift:release-4.4 Apr 26, 2020

Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly #1679

Bug 1826896: [release-4.4] crio: set version-file{,-persist} correctly #1679

Uh oh!

Conversation

haircommander commented Apr 23, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

haircommander commented Apr 23, 2020

Uh oh!

kikisdeliveryservice commented Apr 23, 2020

Uh oh!

mrunalp commented Apr 23, 2020

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

ashcrow commented Apr 25, 2020

Uh oh!

mrunalp commented Apr 25, 2020

Uh oh!

openshift-ci-robot commented Apr 25, 2020

Uh oh!

kikisdeliveryservice commented Apr 25, 2020

Uh oh!

ashcrow commented Apr 25, 2020

Uh oh!

ashcrow commented Apr 25, 2020

Uh oh!

ashcrow commented Apr 25, 2020

Uh oh!

ashcrow commented Apr 25, 2020

Uh oh!

cgwalters commented Apr 25, 2020

Uh oh!

mrunalp commented Apr 25, 2020

Uh oh!

kikisdeliveryservice commented Apr 25, 2020

Uh oh!

openshift-ci-robot commented Apr 25, 2020

Uh oh!

openshift-ci-robot commented Apr 25, 2020

Uh oh!

kikisdeliveryservice commented Apr 25, 2020

Uh oh!

kikisdeliveryservice commented Apr 25, 2020

Uh oh!

kikisdeliveryservice commented Apr 26, 2020

Uh oh!

kikisdeliveryservice commented Apr 26, 2020

Uh oh!

openshift-ci-robot commented Apr 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikisdeliveryservice commented Apr 26, 2020

Uh oh!

openshift-ci-robot commented Apr 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

openshift-ci-robot commented Apr 26, 2020 •

edited

Loading