Skip to content

Conversation

@ondrejmular
Copy link

This is a PoC implementation of openshift/enhancements#159

The main goal of this PR is to get feedback on a mechanism responsible for getting files/units changes and running defined actions to avoid reboots. It was only tested manually and automated tests will be added once there is an agreement that this implementation is acceptable.
Filter defined in the code is (obviously) just a placeholder for testing and the final filter definition still needs to be agreed on.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ondrejmular
To complete the pull request process, please assign ericavonb
You can assign the PR to them by writing /assign @ericavonb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ondrejmular
Copy link
Author

cc @beekhof

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2020
@openshift-ci-robot
Copy link
Contributor

@ondrejmular: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@ondrejmular: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@ondrejmular: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit f2b0f42 link /test unit
ci/prow/verify f2b0f42 link /test verify
ci/prow/e2e-gcp-op f2b0f42 link /test e2e-gcp-op
ci/prow/e2e-aws-scaleup-rhel7 f2b0f42 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-ovn-step-registry f2b0f42 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@beekhof
Copy link

beekhof commented Jul 16, 2020

Replaced by #1922

/close

@openshift-ci-robot
Copy link
Contributor

@beekhof: Closed this PR.

Details

In response to this:

Replaced by #1922

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants