Misc clean up #162
Merged
Misc clean up #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Milner <smilner@redhat.com>
- allow_noent -> allowNoent - drop unneeded else statement Signed-off-by: Steve Milner <smilner@redhat.com>
Signed-off-by: Steve Milner <smilner@redhat.com>
openshift-ci-robot
added
size/S
yuqi-zhang
approved these changes
Nov 9, 2018
Contributor
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
Looks good in terms of the comments from the other PR. Will let others merge.
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
…-spec Bug 1734627: preserve deleted EOL ISTs on upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up PR per:
/cc @kikisdeliveryservice @miabbott