Bug 1825967: etcd quorum guard: don't set hostNetwork #1552
Conversation
Prepare the script once so that readinessProbe command would not look for certificate path every time. This also uses downward API to avoid looking for certificates and fetch them from defined locations
openshift-ci-robot
added
the
size/M
|
@hexfusion ptal |
|
In general, if this works I am fine with it. |
Avoid setting hostNetwork for etcd-quorum-guard
vrutkovs
force-pushed
the
etcd-quorum-no-hostnetwork
branch
from
2867fbf to
0c666f6
Compare
|
PTAL: @alaypatel07 @retroflexer |
|
prow is down waiting for retest. |
|
/retest |
1 similar comment
|
/retest |
|
Throttling /retest |
|
/test e2e-vsphere |
|
Thanks @vrutkovs great find. As per slack conversation we are going to let this soak for a bit in 4.5 before we backport just in case. /lgtm |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, retroflexer, vrutkovs, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold GCP upgrades are not passing anymore. Lets see if removing the namespace and a rebuild helps |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this vsphere test has passed once in 87 runs overall so I really don't think we should keep running it. will report/file a bugzilla for it: /skip |
|
@jcpowermac PTAL, machine-api is unhappy in vsphere tests |
|
I opened BZ 1813026 to track vsphere e2e failures. |
|
/retitle Bug 1825967: etcd quorum guard: don't set hostNetwork |
openshift-ci-robot
changed the title
|
@vrutkovs: All pull requests linked via external trackers have merged: . Bugzilla bug 1825967 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
10 participants
- What I did
updated
etcd-quorum-guarddeployment to generate readiness script once and use host IP and name to find certificates in defined locations.removed
hostNetwork: truefrom this deployment.This caused all network traffic to be counted as a container traffic, so some pods had > 4MBps network in/out in console
- How to verify it
Run setup / upgrade.
Check network in/out data for etcd-quorum pods
- Description for the changelog