Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2018
@abhinavdahiya abhinavdahiya changed the title templates: use clsuter-name.base-domain for etcd srv search templates: use cluster-name.base-domain for etcd srv search Nov 2, 2018
@abhinavdahiya
Copy link
Contributor Author

openshift/installer#596 merged
/retest

Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor Author

/test e2e-aws

@abhinavdahiya
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor Author

Release payload push failed.

/retest

@abhinavdahiya
Copy link
Contributor Author

aws_route53_record.etcd_cluster: Creating...
  fqdn:               "" => "<computed>"
  name:               "" => "_etcd-server-ssl._tcp"
  records.#:          "" => "3"
  records.1175921606: "" => "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-2.origin-ci-int-aws.dev.rhcloud.com"
  records.3452181983: "" => "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-1.origin-ci-int-aws.dev.rhcloud.com"
  records.39455255:   "" => "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-0.origin-ci-int-aws.dev.rhcloud.com"
  ttl:                "" => "60"
  type:               "" => "SRV"
  zone_id:            "" => "Z1H0C8K2M9RVTE"
aws_route53_record.etcd_cluster: Still creating... (10s elapsed)
aws_route53_record.etcd_cluster: Still creating... (20s elapsed)
aws_route53_record.etcd_cluster: Still creating... (30s elapsed)
aws_route53_record.etcd_cluster: Still creating... (40s elapsed)
aws_route53_record.etcd_cluster: Creation complete after 46s (ID: Z1H0C8K2M9RVTE__etcd-server-ssl._tcp_SRV)

Apply complete! Resources: 155 added, 0 changed, 0 destroyed.

The installer only created etcd_cluster, no etcd_cluster_old_srvs hmmm :/

/test e2e-aws

@abhinavdahiya
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor Author

[6:51:51]~ AWS_PROFILE=ci aws route53 list-resource-record-sets --hosted-zone-id Z13OCQKD0KRW5T
{
    "ResourceRecordSets": [
        {
            "Name": "origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "NS",
            "TTL": 172800,
            "ResourceRecords": [
                {
                    "Value": "ns-1536.awsdns-00.co.uk."
                },
                {
                    "Value": "ns-0.awsdns-00.com."
                },
                {
                    "Value": "ns-1024.awsdns-00.org."
                },
                {
                    "Value": "ns-512.awsdns-00.net."
                }
            ]
        },
        {
            "Name": "origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "SOA",
            "TTL": 900,
            "ResourceRecords": [
                {
                    "Value": "ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400"
                }
            ]
        },
        {
            "Name": "_etcd-server-ssl._tcp.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "SRV",
            "TTL": 60,
            "ResourceRecords": [
                {
                    "Value": "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-2.origin-ci-int-aws.dev.rhcloud.com"
                },
                {
                    "Value": "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-1.origin-ci-int-aws.dev.rhcloud.com"
                },
                {
                    "Value": "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-0.origin-ci-int-aws.dev.rhcloud.com"
                }
            ]
        },
        {
            "Name": "ci-op-m9w3qrw3-c4a31-api.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "A",
            "AliasTarget": {
                "HostedZoneId": "Z35SXDOTRQ7X7K",
                "DNSName": "internal-ci-op-m9w3qrw3-c4a31-int-1521126983.us-east-1.elb.amazonaws.com.",
                "EvaluateTargetHealth": true
            }
        },
        {
            "Name": "ci-op-m9w3qrw3-c4a31-etcd-0.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "A",
            "TTL": 60,
            "ResourceRecords": [
                {
                    "Value": "10.0.0.41"
                }
            ]
        },
        {
            "Name": "ci-op-m9w3qrw3-c4a31-etcd-1.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "A",
            "TTL": 60,
            "ResourceRecords": [
                {
                    "Value": "10.0.30.240"
                }
            ]
        },
        {
            "Name": "ci-op-m9w3qrw3-c4a31-etcd-2.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "A",
            "TTL": 60,
            "ResourceRecords": [
                {
                    "Value": "10.0.38.131"
                }
            ]
        },
        {
            "Name": "ci-op-m9w3qrw3-c4a31.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "A",
            "AliasTarget": {
                "HostedZoneId": "Z35SXDOTRQ7X7K",
                "DNSName": "ci-op-m9w3qrw3-c4a31-con-2026131345.us-east-1.elb.amazonaws.com.",
                "EvaluateTargetHealth": true
            }
        },
        {
            "Name": "\\052.ci-op-m9w3qrw3-c4a31.origin-ci-int-aws.dev.rhcloud.com.",
            "Type": "A",
            "AliasTarget": {
                "HostedZoneId": "Z35SXDOTRQ7X7K",
                "DNSName": "ci-op-m9w3qrw3-c4a31-con-2026131345.us-east-1.elb.amazonaws.com.",
                "EvaluateTargetHealth": true
            }
        }
    ]
}

the ci is still using old installer :/

@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@abhinavdahiya abhinavdahiya added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@abhinavdahiya
Copy link
Contributor Author

@crawford force pushed with no extra changes 😇 to unstick ci . adding lgtm manually.

@openshift-merge-robot openshift-merge-robot merged commit b792dec into openshift:master Nov 2, 2018
@abhinavdahiya abhinavdahiya deleted the subdomain_etcd_srvs branch November 2, 2018 02:32
abhinavdahiya added a commit to abhinavdahiya/machine-config-operator that referenced this pull request Nov 2, 2018
openshift#155 missed changing the
--discovery-srv flag on etcd to cluster-name.basedomain
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
…tions

resurface import errors into cluster operator condidtions (phase one,…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants