-
Notifications
You must be signed in to change notification settings - Fork 462
templates: use cluster-name.base-domain for etcd srv search #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates: use cluster-name.base-domain for etcd srv search #155
Conversation
|
openshift/installer#596 merged |
crawford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/retest |
|
Release payload push failed. /retest |
aws_route53_record.etcd_cluster: Creating...
fqdn: "" => "<computed>"
name: "" => "_etcd-server-ssl._tcp"
records.#: "" => "3"
records.1175921606: "" => "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-2.origin-ci-int-aws.dev.rhcloud.com"
records.3452181983: "" => "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-1.origin-ci-int-aws.dev.rhcloud.com"
records.39455255: "" => "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-0.origin-ci-int-aws.dev.rhcloud.com"
ttl: "" => "60"
type: "" => "SRV"
zone_id: "" => "Z1H0C8K2M9RVTE"
aws_route53_record.etcd_cluster: Still creating... (10s elapsed)
aws_route53_record.etcd_cluster: Still creating... (20s elapsed)
aws_route53_record.etcd_cluster: Still creating... (30s elapsed)
aws_route53_record.etcd_cluster: Still creating... (40s elapsed)
aws_route53_record.etcd_cluster: Creation complete after 46s (ID: Z1H0C8K2M9RVTE__etcd-server-ssl._tcp_SRV)
Apply complete! Resources: 155 added, 0 changed, 0 destroyed.The installer only created /test e2e-aws |
|
/retest |
[6:51:51] ➜ ~ AWS_PROFILE=ci aws route53 list-resource-record-sets --hosted-zone-id Z13OCQKD0KRW5T
{
"ResourceRecordSets": [
{
"Name": "origin-ci-int-aws.dev.rhcloud.com.",
"Type": "NS",
"TTL": 172800,
"ResourceRecords": [
{
"Value": "ns-1536.awsdns-00.co.uk."
},
{
"Value": "ns-0.awsdns-00.com."
},
{
"Value": "ns-1024.awsdns-00.org."
},
{
"Value": "ns-512.awsdns-00.net."
}
]
},
{
"Name": "origin-ci-int-aws.dev.rhcloud.com.",
"Type": "SOA",
"TTL": 900,
"ResourceRecords": [
{
"Value": "ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400"
}
]
},
{
"Name": "_etcd-server-ssl._tcp.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "SRV",
"TTL": 60,
"ResourceRecords": [
{
"Value": "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-2.origin-ci-int-aws.dev.rhcloud.com"
},
{
"Value": "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-1.origin-ci-int-aws.dev.rhcloud.com"
},
{
"Value": "0 10 2380 ci-op-m9w3qrw3-c4a31-etcd-0.origin-ci-int-aws.dev.rhcloud.com"
}
]
},
{
"Name": "ci-op-m9w3qrw3-c4a31-api.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "A",
"AliasTarget": {
"HostedZoneId": "Z35SXDOTRQ7X7K",
"DNSName": "internal-ci-op-m9w3qrw3-c4a31-int-1521126983.us-east-1.elb.amazonaws.com.",
"EvaluateTargetHealth": true
}
},
{
"Name": "ci-op-m9w3qrw3-c4a31-etcd-0.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "A",
"TTL": 60,
"ResourceRecords": [
{
"Value": "10.0.0.41"
}
]
},
{
"Name": "ci-op-m9w3qrw3-c4a31-etcd-1.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "A",
"TTL": 60,
"ResourceRecords": [
{
"Value": "10.0.30.240"
}
]
},
{
"Name": "ci-op-m9w3qrw3-c4a31-etcd-2.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "A",
"TTL": 60,
"ResourceRecords": [
{
"Value": "10.0.38.131"
}
]
},
{
"Name": "ci-op-m9w3qrw3-c4a31.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "A",
"AliasTarget": {
"HostedZoneId": "Z35SXDOTRQ7X7K",
"DNSName": "ci-op-m9w3qrw3-c4a31-con-2026131345.us-east-1.elb.amazonaws.com.",
"EvaluateTargetHealth": true
}
},
{
"Name": "\\052.ci-op-m9w3qrw3-c4a31.origin-ci-int-aws.dev.rhcloud.com.",
"Type": "A",
"AliasTarget": {
"HostedZoneId": "Z35SXDOTRQ7X7K",
"DNSName": "ci-op-m9w3qrw3-c4a31-con-2026131345.us-east-1.elb.amazonaws.com.",
"EvaluateTargetHealth": true
}
}
]
}the ci is still using old installer :/ |
4c2a9f0 to
c91b9c4
Compare
|
New changes are detected. LGTM label has been removed. |
|
@crawford force pushed with no extra changes 😇 to unstick ci . adding lgtm manually. |
openshift#155 missed changing the --discovery-srv flag on etcd to cluster-name.basedomain
…tions resurface import errors into cluster operator condidtions (phase one,…
Requires: openshift/installer#596
/cc @crawford