Skip to content

Conversation

@hardys
Copy link

@hardys hardys commented Mar 9, 2020

This was added in #1206 to the base unit, but not the baremetal
copy of this file

- What I did
Added a dependency on the network-online target for the baremetal copy of the kubelet unit file.

- How to verify it
Verify the unit file on a IPI baremetal deployment or via systemctl list-dependencies

- Description for the changelog
Added missing dependency for kubelet on the network-online target, for the baremetal platform.

This was added in openshift#1206 to the base unit, but not the baremetal
copy of this file
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2020
@hardys
Copy link
Author

hardys commented Mar 9, 2020

/retitle Bug 1811758 : baremetal: Add missing network-online dependency to kubelet unit

@openshift-ci-robot openshift-ci-robot changed the title baremetal: Add missing network-online dependency to kubelet unit Bug 1811758 : baremetal: Add missing network-online dependency to kubelet unit Mar 9, 2020
@hardys
Copy link
Author

hardys commented Mar 9, 2020

/cc @russellb @celebdor

@sjenning
Copy link
Contributor

sjenning commented Mar 9, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 169bd69 into openshift:master Mar 9, 2020
@russellb
Copy link
Contributor

russellb commented Mar 9, 2020

/cherry-pick release-4.4

@russellb
Copy link
Contributor

russellb commented Mar 9, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@russellb: new pull request created: #1548

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@russellb: new pull request created: #1549

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

Arrrgh! We need to dedup this stuff.

@openshift-ci-robot
Copy link
Contributor

@hardys: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 2d7ce47 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants