-
Notifications
You must be signed in to change notification settings - Fork 462
Bug 1811758 : baremetal: Add missing network-online dependency to kubelet unit #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1811758 : baremetal: Add missing network-online dependency to kubelet unit #1547
Conversation
This was added in openshift#1206 to the base unit, but not the baremetal copy of this file
|
/retitle Bug 1811758 : baremetal: Add missing network-online dependency to kubelet unit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-4.4 |
|
/cherry-pick release-4.3 |
|
@russellb: new pull request created: #1548 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@russellb: new pull request created: #1549 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Arrrgh! We need to dedup this stuff. |
|
@hardys: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This was added in #1206 to the base unit, but not the baremetal
copy of this file
- What I did
Added a dependency on the network-online target for the baremetal copy of the kubelet unit file.
- How to verify it
Verify the unit file on a IPI baremetal deployment or via
systemctl list-dependencies- Description for the changelog
Added missing dependency for kubelet on the network-online target, for the baremetal platform.