Skip to content

Conversation

@hexfusion
Copy link
Contributor

We are migrating quorum-guard to the openshift-etcd namespace. The reason it originally lived here was that we did not have an operator to take reference to the cli image it uses.

depends on openshift/cluster-etcd-operator#142

Signed-off-by: Sam Batschelet <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2020
@hexfusion
Copy link
Contributor Author

/hold

for openshift/cluster-etcd-operator#142

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2020
@abhinavdahiya
Copy link
Contributor

hmm.. cvo doesn't clean up / prune removed deployments (or any other object) from release images, i think mco / ceo will have to take ownership of that.

@hexfusion
Copy link
Contributor Author

hmm.. cvo doesn't clean up / prune removed deployments (or any other object) from release images, i think mco / ceo will have to take ownership of that.

yeah good point to manage this we have a controller "guardbudget" that will handle this teardown this on CEO end.

@hexfusion
Copy link
Contributor Author

/retest

@kikisdeliveryservice
Copy link
Contributor

/skip

@hexfusion
Copy link
Contributor Author

/retest

@ashcrow ashcrow removed their request for review February 18, 2020 14:04
@alaypatel07
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alaypatel07, hexfusion
To complete the pull request process, please assign sinnykumari
You can assign the PR to them by writing /assign @sinnykumari in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Feb 18, 2020

/test all

@cgwalters
Copy link
Member

etcd has left the building

@openshift-ci-robot
Copy link
Contributor

@hexfusion: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 01d70d6 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice kikisdeliveryservice requested review from runcom and removed request for yuqi-zhang February 19, 2020 01:07
@runcom
Copy link
Member

runcom commented Feb 19, 2020

depends on openshift/cluster-etcd-operator#142

this PR has been closed 🤔 does this still depend on something?

@hexfusion
Copy link
Contributor Author

we are not going to go this route in 4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants