-
Notifications
You must be signed in to change notification settings - Fork 462
*: remove etcd quorum guard #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sam Batschelet <[email protected]>
|
/hold |
|
hmm.. cvo doesn't clean up / prune removed deployments (or any other object) from release images, i think mco / ceo will have to take ownership of that. |
yeah good point to manage this we have a controller "guardbudget" that will handle this teardown this on CEO end. |
|
/retest |
|
/skip |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alaypatel07, hexfusion The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
|
etcd has left the building |
|
@hexfusion: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
this PR has been closed 🤔 does this still depend on something? |
|
we are not going to go this route in 4.4 |
We are migrating
quorum-guardto theopenshift-etcdnamespace. The reason it originally lived here was that we did not have an operator to take reference to the cli image it uses.depends on openshift/cluster-etcd-operator#142