mcd: fix race condition for annotation updates #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we finish an update, we re-check the desired config and indiscriminately set the current config to it. This can cause an update to be lost since the desired config may have changed inbetween the isDesired check and when the map is updated. Instead we should be updating the config to the one we checked for in isDesired. Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
openshift-ci-robot
added
the
size/M
Member
|
Awesome, great catch! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Author
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
/test e2e-aws |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
fix clusteroperator related-objects, set with updatestatus vs. create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we finish an update, we re-check the desired config
and indiscriminately set the current config to it. This can cause
an update to be lost since the desired config may have changed
inbetween the isDesired check and when the map is updated. Instead
we should be updating the config to the one we checked for in
isDesired.
Tested the update process, seems fine to work.