Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1442

/assign LorbusChris

This would ensure masters / workers would report as healthy to GCP LBs
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign yuqi-zhang
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Contributor

vrutkovs commented Feb 6, 2020

The installer PR for bootstrap - openshift/installer#3071 - won't pass shellcheck. Should be hold this one until it merges in installer first so that we wouldn't diverge?

@LorbusChris
Copy link
Contributor

👍 We'll have to re-create this PR anyway if it can't merge as-is, or can I actually push into the cherrypick-robot's branch?
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@vrutkovs
Copy link
Contributor

vrutkovs commented Feb 6, 2020

I'd rather go with recreate - repo admins can push to this branch though

@LorbusChris LorbusChris self-requested a review February 6, 2020 20:26
@LorbusChris
Copy link
Contributor

Superseded by #1449
/close

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: Closed this PR.

Details

In response to this:

Superseded by #1449
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws ab27800 link /test e2e-aws
ci/prow/e2e-aws-scaleup-rhel7 ab27800 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants