Skip to content

Bug 1798639: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 13, 2020
Merged

Bug 1798639: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config #1441

openshift-merge-robot merged 1 commit into from
Feb 13, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 5, 2020

This is an automated cherry-pick of #1395

/assign hardys

baremetal add dhcp-duid to NetworkManager config
351b87e 
Adding ipv6.dhcp-duid=ll means we get a predictable
client ID so that reservations can be made on the
DHCP server - this is useful if you want to provide
the hostname via DHCP (although a reverse DNS lookup
should also work)

Reservations are also required to ensure the controlplane
IP of the masters won't ever change post-deployment
which will be necessary if the DNS lookup approach
is taken to set the hostnames.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2020
@hardys
Copy link

hardys commented Feb 5, 2020

/retitle Bug 1798637: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config Bug 1798637: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1798637, which is invalid:

  • expected Bugzilla bug 1798637 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1798637: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 5, 2020
@hardys
Copy link

hardys commented Feb 5, 2020

/retitle Bug 1798639: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config

@openshift-ci-robot openshift-ci-robot changed the title Bug 1798637: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config Bug 1798639: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1798639, which is invalid:

  • expected dependent Bugzilla bug 1798637 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1798639: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb
Copy link
Contributor

russellb commented Feb 12, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2020

@russellb: This pull request references Bugzilla bug 1798639, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

sinnykumari commented Feb 12, 2020

/skip e2e-aws-scaleup-rhel7
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@russellb
Copy link
Contributor

russellb commented Feb 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, russellb, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 13, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5c8eedd into openshift:release-4.3 Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1798639 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1798639: [release-4.3] baremetal: IPv6 add dhcp-duid to NetworkManager config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@russellb russellb

@hardys hardys

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @hardys @russellb @sinnykumari @openshift-bot @mfojtik @openshift-merge-robot